Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid column headers vertically misaligned when some are sortable #5940

Closed
2 tasks done
wkeese opened this issue Aug 24, 2024 · 0 comments · Fixed by #5994
Closed
2 tasks done

Datagrid column headers vertically misaligned when some are sortable #5940

wkeese opened this issue Aug 24, 2024 · 0 comments · Fixed by #5994
Assignees
Labels
component: Datagrid Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working

Comments

@wkeese
Copy link
Contributor

wkeese commented Aug 24, 2024

Package

Carbon for IBM Products

Description

With the combination of rowSize="xl" and a table where some of the columns are sortable, the headers are not vertically aligned:

Screenshot 2024-08-24 at 11 27 21

There's a similar problem for rowsize=md, so that needs to be fixed too.

This used to be a generic problem with Carbon, see carbon-design-system/carbon#9311, but it was fixed in 2022, so presumably this is a @carbon/ibm-products bug.

I see that @carbon/ibm-products' markup is very different than plain carbon. See https://react.carbondesignsystem.com/?path=/story/components-datatable-sorting--playground for comparison. For example, @carbon/ibm-products doesn't use the cds--table-sort__header class.

Component(s) impacted

Datagrid

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.46

Suggested Severity

None

Product/offering

IKC

CodeSandbox or Stackblitz example

https://stackblitz.com/edit/github-qcefwb?file=src%2FExample%2FExample.jsx

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@amal-k-joy amal-k-joy added type: bug 🐛 Something isn't working component: Datagrid Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. and removed status: needs triage 🕵️‍♀️ labels Aug 28, 2024
@wkeese wkeese changed the title Datagrid column headers vertically misaligned when rowSize="xl" and some are sortable Datagrid column headers vertically misaligned when some are sortable Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Datagrid Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

2 participants