Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental Component - File Uploader - Design #1255

Closed
3 tasks done
kuehndaniel opened this issue Oct 12, 2018 · 2 comments
Closed
3 tasks done

Experimental Component - File Uploader - Design #1255

kuehndaniel opened this issue Oct 12, 2018 · 2 comments
Assignees
@laurenmrice
Milestone
Carbon X Release:...

Comments

@kuehndaniel
Copy link

kuehndaniel commented Oct 12, 2018 •
edited by laurenmrice
Loading

Design
Create final design specifications that are ready for production. Functionality and variations should match as is Carbon components.

  • confirm Security design matches duo intent
  • confirm Sketch file sizing/spacing specs
  • screen grab sizing guidance and add to GitHub issue
@laurenmrice laurenmrice self-assigned this Oct 30, 2018
@laurenmrice
Copy link
Member

laurenmrice commented Nov 1, 2018 •
edited
Loading

File Uploader

Sketch file: https://ibm.box.com/s/jvywa1198xk4lrwri8oe64qtg2wtbc8d

  • Omitted outer border to be consistent with other patterns
  • Gray 100 icons instead of Gray 70
  • Cursor change on hover only
  • Updated error pattern to be consistent with other error treatments and disabled text
    File Uploader_Light_Theme_White.png
    File Uploader_Light_Theme_White_Specs.png

@laurenmrice
Copy link
Member

Ready for dev ✅ @IBM/carbon-developers
Dev issue: #1296

@laurenmrice laurenmrice mentioned this issue Nov 1, 2018
Closed
2 tasks
@kuehndaniel kuehndaniel mentioned this issue Nov 7, 2018
Closed
This was referenced Feb 7, 2019
Closed
Closed
Merged
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@okstaticzero @joshblack
fix(components): Fix state warning errors (carbon-design-system#1255)
f96e930 
* fix(components): Fix state warning errors

* fix(components): Fix state warning errors

* fix: clean up gDSFP

* chore:update other dDSPS's

* chore: added prop value and min camparison back into cunstructor
@asudoh asudoh mentioned this issue May 14, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurenmrice laurenmrice

Labels
None yet
Projects
None yet
Milestone
Carbon X Release: Eggnog Latte
Development

No branches or pull requests
2 participants
@kuehndaniel @laurenmrice