Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileUploader/FileUploaderButton, react, bug?]: FileUploader & FileUploaderButton component in react adds bx--btn--sm CSS style to the button which is not present in VanillaJS implementation #2715

Closed
1 of 2 tasks
rraavi opened this issue May 14, 2019 · 3 comments
Labels
package: react carbon-components-react type: bug 🐛

Comments

@rraavi
Copy link

rraavi commented May 14, 2019

Packages being used :-

  • carbon-components v10.2.0
  • carbon-components-react v7.2.0

Issue might be localized to following packages :-

  • carbon-components
  • carbon-components-react

Detailed description

Looking at the documentation here, the button for FileUploader should be normal sized and not a small variant button type which is what the current react package has as shown here

Poking around the source code, looks like bx--btn--sm CSS class is being added for FileUploader & FileUploaderButton, which is causing the button to be a small button.

Wondering if this is expected behavior or a bug..? 🤔

Is this issue related to a specific component?
It's limited to FileUploader & FileUploaderButton component

Steps to reproduce the issue

@dakahn dakahn added package: react carbon-components-react priority: high severity: 4 https://ibm.biz/carbon-severity labels May 14, 2019
@asudoh
Copy link
Contributor

asudoh commented May 14, 2019

@emyarod From carbon-design-system/carbon-components-react#1645 I'm getting an impression that the small file uploader button came from v10 design spec, but #1255 gives me an opposite impression. Do you remember anything...? Thanks!

@emyarod
Copy link
Member

emyarod commented May 14, 2019

@asudoh I believe we want to remove the small button class from #2048. My guess is this change was never ported into the React codebase?

@emyarod emyarod added role: visual 🎨 and removed severity: 4 https://ibm.biz/carbon-severity labels Jan 16, 2020
@joshblack joshblack mentioned this issue Mar 5, 2020
82 tasks
@emyarod
Copy link
Member

emyarod commented Mar 6, 2020

This issue is no longer present in the component (ref #5166)

@emyarod emyarod closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react type: bug 🐛
Projects
None yet
Development

No branches or pull requests

5 participants