Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inline loading): audit fixes #2073

Merged
merged 3 commits into from
Jan 11, 2021
Merged

docs(inline loading): audit fixes #2073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f8c623
docs(inline loading): audit fixes
aagonzales Jan 8, 2021
07672d2
Update style.mdx
aagonzales Jan 11, 2021
f21fd9b
Merge branch 'master' into inline-loading
aagonzales Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified src/pages/components/inline-loading/images/inline-loading-style-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/inline-loading/images/inline-loading-style-3.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
48 changes: 22 additions & 26 deletions src/pages/components/inline-loading/style.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,30 @@ tabs: ['Usage', 'Style', 'Code', 'Accessibility']

## Color

| Class | Property | Color token |
| -------------------------------- | -------- | ----------------- |
| `.bx--loading__svg` | stroke | `$ui-03` |
| `.bx--inline-loading__checkmark` | color | `$interactive-01` |
| `.bx--inline-loading__text` | color | `$text-01` |
| Class | Property | Color token |
| --------------------------- | -------- | ----------------- |
| `.bx--loading__background` | stroke | `$ui-03` |
| `.bx--loading__stroke` | stroke | `$interactive-04` |
| `.bx--inline-loading__text` | color | `$text-02` |
| `status: finished` | svg | `$support-02` |
| `status: finished` | svg | `$support-01` |

<Row>
<Column colLg={8}>

![Example of inline loading states](images/inline-loading-states.png)

</Column>
</Row>

## Typography

Button text should be set in sentence case, with only the first word in a phrase
and any proper nouns capitalized.

| Class | Font-size (px/rem) | Font-weight | Type token |
| --------------------------- | ------------------ | ------------- | ---------------- |
| `.bx--inline-loading__text` | 14 / 0.875 | Regular / 400 | `$body-short-01` |
| Class | Font-size (px/rem) | Font-weight | Type token |
| --------------------------- | ------------------ | ------------- | ----------- |
| `.bx--inline-loading__text` | 12 / 0.75 | Regular / 400 | `$label-01` |

## Structure

Expand All @@ -35,22 +45,6 @@ and any proper nouns capitalized.

</div>

<div className="image--fixed">

![Inline loading states](images/inline-loading-style-2.png)

</div>

<div className="image--fixed">

![Inline loading spinner in context example](images/inline-loading-style-3.png)

</div>

<Caption>
Structure measurements for small and large loading spinner | px / rem
</Caption>

### Placement

The inline loading component should appear during any user action loading. If
Expand All @@ -59,8 +53,10 @@ replace that button.

<div className="image--fixed">

![Inline loading spinner animated_in context example](images/inline-loading-animated.gif)
![Inline loading spinner in context example](images/inline-loading-style-3.png)

</div>

<Caption>Example of a inline loading in product context</Caption>
<Caption>
Structure measurements for small and large loading spinner | px / rem
</Caption>