Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inline loading): audit fixes #2073

Merged
merged 3 commits into from
Jan 11, 2021
Merged

docs(inline loading): audit fixes #2073

merged 3 commits into from
Jan 11, 2021

Conversation

aagonzales
Copy link
Member

Closes #2059

  • Loading text to be text-02
  • loading stroke be interactive-04
  • Added finished and error states to color section
  • inline-loading__text should be 12px, label-01
  • Updates states image (color section)
  • Update images

@aagonzales aagonzales requested a review from a team January 8, 2021 20:00
@aagonzales aagonzales requested a review from a team as a code owner January 8, 2021 20:00
@vercel
Copy link

vercel bot commented Jan 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/eouz38216
✅ Preview: https://carbondesignsystem-git-fork-aagonzales-inline-loading.carbon-design-system.vercel.app

laurenmrice
laurenmrice requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-This old states image is still appearing:
Screen Shot 2021-01-08 at 3 51 06 PM

-The Placement image/gif is not loading for me still.
Screen Shot 2021-01-08 at 3 56 03 PM

@aagonzales
Copy link
Member Author

Oh weird some of my changes didn't show up in the preview link. It should be correct now. @laurenmrice

laurenmrice
laurenmrice approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq bot merged commit 50e05f4 into carbon-design-system:master Jan 11, 2021
@aagonzales aagonzales deleted the inline-loading branch January 11, 2021 19:38
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@aagonzales @natashadecoste
docs(inline loading): audit fixes (carbon-design-system#2073)
32f4e79 
* docs(inline loading): audit fixes

* Update style.mdx
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@aagonzales @natashadecoste
docs(inline loading): audit fixes (carbon-design-system#2073)
781d00a 
* docs(inline loading): audit fixes

* Update style.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@janchild janchild janchild approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[inline loading] audit bugs
4 participants
@aagonzales @joshblack @laurenmrice @janchild