Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs (dropdown): usage image update #1282

Merged
merged 1 commit into from
Jun 12, 2020
Merged

docs (dropdown): usage image update #1282

merged 1 commit into from
Jun 12, 2020

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Jun 11, 2020 •
edited
Loading

Related issues:
carbon-design-system/carbon#6205
carbon-design-system/carbon#6195

Update scrolling crop image to show 5.5 options in a menu before scroll, instead of 4.5.

@laurenmrice laurenmrice requested a review from a team as a code owner June 11, 2020 14:23
@vercel
Copy link

vercel bot commented Jun 11, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/ezmnib6e1
✅ Preview: https://carbon-website-git-fork-laurenmrice-laurenmrice-dropdow-adcadc.carbon-design-system.vercel.app

@ghost ghost requested review from aledavila and emyarod June 11, 2020 14:23
@laurenmrice laurenmrice requested review from jeanservaas, a team and jillianhowarth and removed request for aledavila June 11, 2020 14:23
janchild
janchild approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@laurenmrice laurenmrice removed the request for review from jillianhowarth June 11, 2020 15:15
emyarod
emyarod reviewed Jun 11, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like dropdown-usage-7.png is conflicting with a file that already exists in the repo

jeanservaas
jeanservaas reviewed Jun 11, 2020
View reviewed changes
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should just go ahead and change these targets to magenta like on Tyler's data table

I have it as 20% magenta normal opacity

image

@laurenmrice
Copy link
Member Author

yeah i will update that here too @jeanservaas

emyarod
emyarod approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@laurenmrice laurenmrice merged commit 209a6a4 into carbon-design-system:master Jun 12, 2020
@laurenmrice laurenmrice deleted the laurenmrice-dropdown-usage-image branch June 12, 2020 15:58
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@laurenmrice @natashadecoste
update: interaction images and scrolling content (carbon-design-syste…
05fe7ae 
…m#1282)

Co-authored-by: Lauren Rice <[email protected]>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@laurenmrice @natashadecoste
update: interaction images and scrolling content (carbon-design-syste…
5b72e91 
…m#1282)

Co-authored-by: Lauren Rice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@jeanservaas jeanservaas jeanservaas approved these changes

@janchild janchild janchild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurenmrice @emyarod @jeanservaas @janchild