Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dropdown] change cropped option before scroll #6195

Closed
laurenmrice opened this issue Jun 3, 2020 · 1 comment · Fixed by #6205
Closed

[dropdown] change cropped option before scroll #6195

laurenmrice opened this issue Jun 3, 2020 · 1 comment · Fixed by #6205
Assignees
@tw15egan
Labels
component: dropdown package: components carbon-components role: dev 🤖 type: enhancement 💡

Comments

@laurenmrice
Copy link
Member

When a dropdown is open, we need to change the crop of an option before scroll to the 6th option instead of the 4th option.

Spec:
dropdown-usage-7 copy
@laurenmrice laurenmrice mentioned this issue Jun 3, 2020
Closed
@mjabbink
Copy link

mjabbink commented Jun 3, 2020

@laurenmrice Perfect! This will be much better.

@alisonjoseph alisonjoseph mentioned this issue Jun 3, 2020
Closed
41 tasks
@tw15egan tw15egan self-assigned this Jun 4, 2020
@tw15egan tw15egan mentioned this issue Jun 5, 2020
Merged
3 tasks
@laurenmrice laurenmrice mentioned this issue Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
component: dropdown package: components carbon-components role: dev 🤖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dropdown): increase max-height for all dropdown variants tw15egan/carbon
4 participants
@joshblack @tw15egan @mjabbink @laurenmrice