Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-app): convert statusIndicator yaml file into js, remove withYaml #1466

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

francinelucca
Copy link
Collaborator

@francinelucca francinelucca commented Oct 28, 2022

Closes #1413

Worked with @andreancardona on this over on #1423 but pulling out into separate PR so we can close it since that PR is deferred 🚀

TODO:

  • have sonarcloud ignore data folder in webapp

Changelog

New

  • status-inidcators.js

Removed

  • status-indicators.yaml
  • next-plugin-yaml dependency

Testing / reviewing

App should continue to work as expected

@carbon-bot
Copy link
Contributor

The commits in this PR will result in the following version changes:

🐛 PATCH release: @carbon-platform/web-app

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.8% 12.8% Duplication

@jharvey10
Copy link
Contributor

Regarding the sonarcloud duplication issue, we likely want to ignore the data folder entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove YAML loader in favor of JS modules
3 participants