feat: convert mdx components in web app to mdx-components package #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-package' of https://github.com/carbon-design-system/carbon-platform into 1103-convert-mdx-components-in-web-app-to-mdx-components-package
…s-package' of https://github.com/carbon-design-system/carbon-platform into 1103-convert-mdx-components-in-web-app-to-mdx-components-package
58 tasks
|
@jdharvey-ibm @alisonjoseph we shouldn't need this page, once all of these MDX components are documented in individual Storybook stories. |
|
@mattrosno @jdharvey-ibm Let's wait until everything looks good and is approved before removing the test mdx pages, so we can review things in the site easily and compare to live. |
alisonjoseph
reviewed
Oct 7, 2022
Co-authored-by: Joe Harvey <[email protected]>
Co-authored-by: Andrea N. Cardona <[email protected]>
francinelucca
added
status: ready for review 👀
and removed
status: failing CI 🙅♂️
status: WIP 👩💻
labels
francinelucca
requested review from
andreancardona,
francinelucca and
a team
as code owners
Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: Francine Lucca <[email protected]>
Co-authored-by: Andrea N. Cardona <[email protected]>
francinelucca
approved these changes
Nov 10, 2022
|
we removed most prop warnings @jdharvey-ibm and the ones left behind are reasonable! |
Co-authored-by: Francine Lucca <[email protected]>
- fix title to use h4 without autolink (use p instead of an h4) - adjust style of some components as siblings of headers - add new "header" utility class to h1-h4 Co-authored-by: Francine Lucca <[email protected]>
|
❗ The commits in this PR will result in the following version changes: 🌟 MINOR release: |
|
Kudos, SonarCloud Quality Gate passed! |
jharvey10
deleted the
1103-convert-mdx-components-in-web-app-to-mdx-components-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1103
Closes #1384
Closes #1413
Closes #1496
Things to check
mdx-components/src/main/index.ts?mdx-components/src/main/index.scss?Open questions
pages/mdxfiles. Should they be roped into the storybook stories in the mdx-components package? (Web-App: remove mdx sample pages #1499)Testing / reviewing
Compare the component visuals and functionality to what they were before the conversion.