Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-App: CodeSnippet styling issues #1384

Open
3 tasks
francinelucca opened this issue Sep 30, 2022 · 6 comments · Fixed by #1423
Open
3 tasks

Web-App: CodeSnippet styling issues #1384

francinelucca opened this issue Sep 30, 2022 · 6 comments · Fixed by #1423

Comments

@francinelucca
Copy link
Collaborator

francinelucca commented Sep 30, 2022

Description

  • CodeSnippet usage along with text in a paragraph is overlapping eachother

image

Steps to reproduce

https://next-test.carbondesignsystem.com/libraries/carbon-react/latest/pages/tutorial/step-1
https://next-test.carbondesignsystem.com/common-mdx-errors

  1. Drop these contents into a test.mdx file in services/web-app/pages
Inline styles Inline styles in the form of string: `style="padding-top: 20px; color: red"` instead
  of javascript objects: `style={{paddingTop: '20px', color: 'red'}}` will result in a Component not
  rendering error.
  1. Navigate to http://localhost/test
  2. Make screen size width 320

Note: you can also reproduce this in a *.js file:

  <div>
              Inline styles in the form of string:{' '}
              <CodeSnippet type="inline">{'style="padding-top: 20px; color: red"'}</CodeSnippet>{' '}
              instead of javascript objects:
              <CodeSnippet type="inline">
                {"style={{ paddingTop: '20px', color: 'red' }}"}
              </CodeSnippet>{' '}
              will result in a Component not rendering error.
    </div>
@alisonjoseph
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @andreancardona @francinelucca @jdharvey-ibm

@alisonjoseph
Copy link
Member

need to override max-width on the button

@francinelucca
Copy link
Collaborator Author

made estimate 3 since added new discovery

@francinelucca francinelucca changed the title Web-App: CodeSnippet overlapping text Web-App: CodeSnippet styling issues Oct 7, 2022
@jharvey10
Copy link
Contributor

If a button can't be "inline", then we'll likely need to not use the carbon snippet component and instead hand-code the styles for this and make them inline so they can wrap onto more than one line.

@alisonjoseph
Copy link
Member

Agreed, wondering if thats why we hand-coded this over in Gatsby 😅

@francinelucca
Copy link
Collaborator Author

reopening, this hasn't been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants