Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1123 common mdx error documentation updates #1383

Merged
merged 5 commits into from
Oct 10, 2022
Merged

1123 common mdx error documentation updates #1383

merged 5 commits into from
Oct 10, 2022

Conversation

francinelucca
Copy link
Collaborator

@francinelucca francinelucca commented Sep 30, 2022 •
edited
Loading

Closes #1123

Implements new styles for common mdx errors page.

Can't put this into SB yet since most of the components used in the page haven't been migrated to mdx-components yet, will put on storybook once #1103 completes (Tracked Here #1430)

Redline: https://www.figma.com/file/WyfqQh9R1VXYZErfmsNDVH/Platform_MDXerrors?node-id=317%3A11968

Note:

Changelog

Changed

  • Converted common errors mdx page into a .js page to prepare for storybook migration, also added styling according to redlines pattern

Testing / reviewing

http://localhost:3000/common-mdx-errors

@francinelucca francinelucca linked an issue Sep 30, 2022 that may be closed by this pull request
Common MDX error documentation updates #1123
Closed
4 tasks
@francinelucca francinelucca marked this pull request as ready for review September 30, 2022 19:18
andreancardona
andreancardona reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing some weird sizes on different MD and SM breakpoints - let me know your thoughts! :)
Screen Shot 2022-10-06 at 9 48 49 AM
Screen Shot 2022-10-06 at 9 50 28 AM

alisonjoseph
alisonjoseph requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small missing token, I'm also seeing the incorrect col width for the notifications at sm/md, but possibly unrelated to this PR? They should match the paragraph width I believe.

services/web-app/pages/common-mdx-errors/index.module.scss Outdated Show resolved Hide resolved
@francinelucca
Copy link
Collaborator Author

Small missing token, I'm also seeing the incorrect col width for the notifications at sm/md, but possibly unrelated to this PR? They should match the paragraph width I believe.

thanks! will fix. Col issues are general and documented here #1364

@francinelucca
Copy link
Collaborator Author

@andreancardona fixed columns, the small screen white space issue is documented in #1384

andreancardona
andreancardona approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 💯

@carbon-bot
Copy link
Contributor

❗ The commits in this PR will result in the following version changes:

🐛 PATCH release: @carbon-platform/web-app

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@francinelucca francinelucca merged commit 696a0e0 into main Oct 10, 2022
@francinelucca francinelucca deleted the 1123-common-mdx-error-documentation-updates branch October 10, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@andreancardona andreancardona andreancardona approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Common MDX error documentation updates
4 participants
@francinelucca @carbon-bot @alisonjoseph @andreancardona