This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
732 search #929
Closed
732 search #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Update .babelrc, resolves #885 * chore: Update pacage.json, resolves #885
… flatpickr (carbon-design-system#887) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr * Updated story description
…design-system#872) * fix: Pagination component's range and page text for no items, resolves #553 * fix: Update UTs for PaginationV2
…#897) * fix(package): update flatpickr to version 4.5.0 Closes carbon-design-system#893 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile
asudoh
reviewed
May 25, 2018
There was a problem hiding this comment.
Thanks @aledavila for working on this! In addition my comment I put to another place, we need to make sure rebasing this PR to latest v9 - Thanks!
| @@ -124,13 +114,6 @@ export default class Search extends Component { | |||
| aria-label={closeButtonLabelText}> | |||
| <Icon name="close--glyph" description="close" /> | |||
| </button> | |||
| {children} | |||
There was a problem hiding this comment.
Did you mean removing support for children altogether...?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves
https://github.ibm.com/carbon/issues/issues/732
Deprecated search with icons.
Removed
Removed search with icons
Changed
Changed close button offset to default 12px because Search with icons is deprecated.