This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix: Pagination component's range and page text for no items #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McBrosa
force-pushed
the
fix-page-menu-no-items
branch
from
844b639
to
4a0f1f0
Compare
Om1986
approved these changes
May 10, 2018
|
They are similar but I believe there are still aspects of #533 that are not resolved in #755. Result: |
|
🎉 This PR is included in version 5.50.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kiett
pushed a commit
to kiett/carbon-components-react
that referenced
this pull request
May 25, 2018
…design-system#872) * fix: Pagination component's range and page text for no items, resolves #553 * fix: Update UTs for PaginationV2
alisonjoseph
added a commit
that referenced
this pull request
May 30, 2018
* chore: Update .babelrc, resolves #885 (#886) * chore: Update .babelrc, resolves #885 * chore: Update pacage.json, resolves #885 * chore(build): fix babel config for test (#892) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr (#887) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr * Updated story description * fix: Pagination component's range and page text for no items (#872) * fix: Pagination component's range and page text for no items, resolves #553 * fix: Update UTs for PaginationV2 * feat(SearchFilterButton): add support for attaching event handlers (#896) * fix(DatePicker): treat Flatpickr's default export as a constructor (#890) Fixes #491. * fix: console.errors coming from using Datepicker (#899) * fix(package): update flatpickr to version 4.5.0 (#897) * fix(package): update flatpickr to version 4.5.0 Closes #893 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile * fix(table-toolbar-search): add i18n support (#903) * fix(OverflowMenu): fix <ClickOutside> not covering floating menu (#906) Fixes #628. * fix(icon-skeleton): Add missing export for IconSkeleton component (#917) * fix(Search): make search icon description translatable (#927) Fixes #923. * fix(Tooltip): prevent aria-owns attribute being set unless the target really exists (#926) Fixes #913. * feat(slider): Add light prop to slider
joshblack
pushed a commit
that referenced
this pull request
Jun 4, 2018
* chore: Update .babelrc, resolves #885 (#886) * chore: Update .babelrc, resolves #885 * chore: Update pacage.json, resolves #885 * chore(build): fix babel config for test (#892) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr (#887) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr * Updated story description * fix: Pagination component's range and page text for no items (#872) * fix: Pagination component's range and page text for no items, resolves #553 * fix: Update UTs for PaginationV2 * feat(SearchFilterButton): add support for attaching event handlers (#896) * fix(DatePicker): treat Flatpickr's default export as a constructor (#890) Fixes #491. * fix: console.errors coming from using Datepicker (#899) * fix(package): update flatpickr to version 4.5.0 (#897) * fix(package): update flatpickr to version 4.5.0 Closes #893 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile * fix(table-toolbar-search): add i18n support (#903) * fix(OverflowMenu): fix <ClickOutside> not covering floating menu (#906) Fixes #628. * fix(icon-skeleton): Add missing export for IconSkeleton component (#917) * fix(Search): make search icon description translatable (#927) Fixes #923. * fix(Tooltip): prevent aria-owns attribute being set unless the target really exists (#926) Fixes #913. * feat(slider): Add light prop to slider
joshblack
pushed a commit
that referenced
this pull request
Jun 4, 2018
* chore: Update .babelrc, resolves #885 (#886) * chore: Update .babelrc, resolves #885 * chore: Update pacage.json, resolves #885 * chore(build): fix babel config for test (#892) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr (#887) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr * Updated story description * fix: Pagination component's range and page text for no items (#872) * fix: Pagination component's range and page text for no items, resolves #553 * fix: Update UTs for PaginationV2 * feat(SearchFilterButton): add support for attaching event handlers (#896) * fix(DatePicker): treat Flatpickr's default export as a constructor (#890) Fixes #491. * fix: console.errors coming from using Datepicker (#899) * fix(package): update flatpickr to version 4.5.0 (#897) * fix(package): update flatpickr to version 4.5.0 Closes #893 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile * fix(table-toolbar-search): add i18n support (#903) * fix(OverflowMenu): fix <ClickOutside> not covering floating menu (#906) Fixes #628. * fix(icon-skeleton): Add missing export for IconSkeleton component (#917) * fix(Search): make search icon description translatable (#927) Fixes #923. * fix(Tooltip): prevent aria-owns attribute being set unless the target really exists (#926) Fixes #913. * feat(slider): Add light prop to slider
alisonjoseph
pushed a commit
that referenced
this pull request
Jun 14, 2018
…Menu's open state (#889) * feat(OverflowMenu): added onClose to props to notify menu is closed * feat(OverflowMenu): moved onClose handler to componentDidUpdate * feat(OverflowMenu): moved onClose handler to render() where state.open is surely changed * feat(OverflowMenu): moved onClose handler to componentDidUpdate * feat(OverflowMenu): add onOpen to notify caller menu's open state * feat(OverflowMenu): moved onClose & onOpen handler to componentDidUpdate * feat(OverflowMenu): added onClose to props to notify menu is closed * chore(build): fix babel config for test (#892) * feat(OverflowMenu): moved onClose handler to componentDidUpdate * feat(OverflowMenu): moved onClose handler to render() where state.open is surely changed * feat(OverflowMenu): moved onClose handler to componentDidUpdate * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr (#887) * feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr * Updated story description * fix: Pagination component's range and page text for no items (#872) * fix: Pagination component's range and page text for no items, resolves #553 * fix: Update UTs for PaginationV2 * feat(SearchFilterButton): add support for attaching event handlers (#896) * fix(DatePicker): treat Flatpickr's default export as a constructor (#890) Fixes #491. * fix: console.errors coming from using Datepicker (#899) * fix(package): update flatpickr to version 4.5.0 (#897) * fix(package): update flatpickr to version 4.5.0 Closes #893 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile * fix(table-toolbar-search): add i18n support (#903) * fix(OverflowMenu): fix <ClickOutside> not covering floating menu (#906) Fixes #628. * feat(OverflowMenu): add onOpen to notify caller menu's open state * feat(OverflowMenu): moved onClose & onOpen handler to componentDidUpdate * feat(OverflowMenu): moved onOpen call hook to_handlePlace * feat(OverflowMenu): refine from Josh and Akira's reviews * feat(OverflowMenu): refine from Josh and Akira's reviews * feat(OverflowMenu): refine from Josh and Akira's reviews
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #553
Summary:
When the total items provided to the Pagination component is 0 the correct item and page ranges will be displayed now. (ie. 0-0 of 0 items and 1 of 1 pages, instead of 1-0 of 0 items and 1 of 0 pages)
Additional Notes:
Pagination V2
Pagination
Changelog
Changed