This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 399
feat(skeleton-states): Add Skeleton states #833
Merged
shinytoyrobots
merged 20 commits into
carbon-design-system:master
from
alisonjoseph:skeleton-states
May 9, 2018
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4634ea6
feat: Begin adding skeleton state components
alisonjoseph 75db148
feat(skeleton): Add skeleton states for components
alisonjoseph d5f2363
chore: update import / export for skeleton states
alisonjoseph 2c96373
chore: update exports for skeleton states
alisonjoseph 1479da3
chore: Add export for skeleton state components
alisonjoseph e7ada6f
chore(skeleton): Add tests for all new skeleton state components
alisonjoseph 1527896
chore: fix merge conflicts
alisonjoseph 6ef1643
feat(skeleton-states): Add skeleton state components
alisonjoseph 2dc987b
chore: fix story
alisonjoseph d090308
chore: merge master
alisonjoseph 8b78a92
feat(skeleton-states): Update accordion
alisonjoseph 4f3163e
Merge branch 'master' into skeleton-states
alisonjoseph 11609b8
chore: merge confilicts
alisonjoseph e86bdfc
Merge branch 'master' into skeleton-states
alisonjoseph 8f67309
chore: merge master
alisonjoseph 0f9c1be
feat(skeleton-states): Update data table skeleton
alisonjoseph 164edd9
chore(skeleton-states): fix failing tests
alisonjoseph b738101
chore: Update carbon-components version to pull in skeleton state styles
alisonjoseph 3b215d7
Merge branch 'master' into skeleton-states
alisonjoseph bfb0698
Merge branch 'master' into skeleton-states
tw15egan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import React from 'react'; | ||
import Icon from '../Icon'; | ||
import SkeletonText from '../SkeletonText'; | ||
|
||
export default class AccordionSkeleton extends React.Component { | ||
render() { | ||
const item = ( | ||
<li className="bx--accordion__item"> | ||
<button type="button" className="bx--accordion__heading"> | ||
<Icon className="bx--accordion__arrow" name="chevron--right" /> | ||
<SkeletonText className="bx--accordion__title" /> | ||
</button> | ||
</li> | ||
); | ||
return ( | ||
<ul className="bx--accordion bx--skeleton"> | ||
<li className="bx--accordion__item bx--accordion__item--active"> | ||
<button type="button" className="bx--accordion__heading"> | ||
<Icon className="bx--accordion__arrow" name="chevron--right" /> | ||
<SkeletonText className="bx--accordion__title" /> | ||
</button> | ||
<div className="bx--accordion__content"> | ||
<SkeletonText width="90%" /> | ||
<SkeletonText width="80%" /> | ||
<SkeletonText width="95%" /> | ||
</div> | ||
</li> | ||
{item} | ||
{item} | ||
{item} | ||
</ul> | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export * from './Accordion.Skeleton'; | ||
export default from './Accordion'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import React from 'react'; | ||
|
||
export default class BreadcrumbSkeleton extends React.Component { | ||
render() { | ||
const item = ( | ||
<div className="bx--breadcrumb-item"> | ||
<a href="/#" class="bx--link"> | ||
| ||
</a> | ||
</div> | ||
); | ||
return ( | ||
<div className="bx--breadcrumb bx--skeleton"> | ||
{item} | ||
{item} | ||
{item} | ||
</div> | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export * from './Breadcrumb.Skeleton'; | ||
export default from './Breadcrumb'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this one back after done testing with the staging URL? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! good catch 👍