feat(skeleton-states): Add Skeleton states #833
Conversation
alisonjoseph
requested review from
joshblack,
marijohannessen,
asudoh,
tw15egan and
aledavila
alisonjoseph
changed the title
alisonjoseph
changed the title
There was a problem hiding this comment.
Amazing to see that you got it covered for all components in a short amount of time @alisonjoseph!! I’m thinking that it’s great to have a set of stories that transits from skeleton state to non-skeleton state (e.g. starting with skeleton state and then switches to non-skeleton state in 3 seconds), as IIUC a skeleton UI is a transient version of the corresponding non-skeleton UI. Thanks!
|
@asudoh thats a great idea, would love some help/guidance on the best way to set that up in our storybook? I've also started this code sample that will be linked to from the docs on the website as one example on how to use this https://codesandbox.io/s/wq264y43k8 ("...loading" will be swapped out with a skeleton component once its ready) |
| routes: | ||
| - route: carbon-react-storybook.mybluemix.net | ||
| - route: react.carbondesignsystem.com | ||
| random-route: true |
There was a problem hiding this comment.
Could you revert this one back after done testing with the staging URL? 🙂
|
🎉 This PR is included in version 5.49.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Will need the updated styles from this PR in
carbon-componentscarbon-design-system/carbon#713 to viewRef https://github.ibm.com/carbon/issues/issues/614
Ref https://github.ibm.com/carbon/issues/issues/559
Add skeleton states
Testing / Reviewing
Staging url: http://carbon-storybook-interciliary-isooctane.stage1.mybluemix.net
Changelog
New Skeleton State Components