This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
chore: bump focus-trap-react version #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
6467-update-focus-trap-dependency
branch
from
5cd4547
to
4306d99
Compare
tw15egan
approved these changes
Jul 16, 2020
emyarod
requested review from
a team,
vpicone and
jnm2377
and removed request for
a team
vpicone
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
@emyarod Doesn't look like v7 had any breaking changes, but they added prop-types. We might want to check we're not breaking any of those prop-types. Other than that looks good!
Also, make sure you tag @carbon-design-system/system for reviews so me, Josefina and Scott aren't accidentally pinged for review
emyarod
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
|
it looks like the system devs group is not enabled for this repo |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref carbon-design-system/carbon#6467
This PR upgrades the
focus-trap-reactdependency to include upstream fixes