Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get latest focus-trap-react dependencies on both carbon-components-react v9 #6467

Closed
1 task
ChunxiAlexLuo opened this issue Jul 14, 2020 · 3 comments
Closed
1 task
Assignees

Comments

@ChunxiAlexLuo
Copy link

What package(s) are you using?

  • carbon-components
  • [x ] carbon-components-react

Detailed description

Can we update focus-trap-react dependencies here?

https://github.com/carbon-design-system/carbon-components-react/blob/master/package.json#L136

We always get this bug when using carbon-components-react, which is fixed in the latest focus-trap-react
focus-trap/focus-trap#81

@emyarod
Copy link
Member

emyarod commented Jul 14, 2020

this package is no longer used in v10 (#5260) but we can update the v9 dependency

@ChunxiAlexLuo
Copy link
Author

#5260

Thank you!

@ChunxiAlexLuo ChunxiAlexLuo changed the title get latest focus-trap-react dependencies on both carbon-components-react v9 and v10 get latest focus-trap-react dependencies on both carbon-components-react v9 Jul 14, 2020
@emyarod
Copy link
Member

emyarod commented Jul 27, 2020

resolved in carbon-design-system/carbon-components-react#2427 and released in v6.116.4

@emyarod emyarod closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants