Skip to content

Conversation

@catenacyber
Copy link
Contributor

Following #1478

Patch is now approved on LLVM : https://reviews.llvm.org/D61935
There is still sync tools to run
LLVM updated more than just tbegin and such instructions. So I do not know if you want these or not....

@catenacyber catenacyber mentioned this pull request Jun 26, 2019
@aquynh
Copy link
Collaborator

aquynh commented Jun 26, 2019

can you send a pull req that only fixes #1478, and another issue on PPC you reported last time?

the reason is that if we pick up all these fixes, we may need to sync the decoder & printer code as well.

@catenacyber
Copy link
Contributor Author

I am not sure what you mean.
Do you want me to apply the diff from https://reviews.llvm.org/D61935 ?
This way, we do not get other changes such as VSXReg

Then, we still have to run the sync tools...

@aquynh
Copy link
Collaborator

aquynh commented Jun 27, 2019

we are based on llvm 7.0.1 now, so we just fix bugs we know in that version. by syncing with the latest llvm 8.x TD files, we must sync its code (decoder + printer) as well.

so lets focus on fixing the issues you reported to llvm first, then we see how to sync with other changes later.

@catenacyber
Copy link
Contributor Author

Here we go

@aquynh
Copy link
Collaborator

aquynh commented Jun 27, 2019

this includes some changes to TCHECK, but i dont remember any issues about this instruction?

@catenacyber
Copy link
Contributor Author

Well, oss-fuzz triggered the bugs for TABORT, but the bug is present for all these instructions. (I guess oss-fuzz labelled it as duplicate)

@aquynh aquynh merged commit 839c5e2 into capstone-engine:next Jul 1, 2019
@aquynh
Copy link
Collaborator

aquynh commented Jul 1, 2019

merged, thanks!

@catenacyber
Copy link
Contributor Author

@aquynh it looks like you did not run sync tools after merging this.
Can you do it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants