Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff for join columns #339

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

rhaffar
Copy link
Contributor

@rhaffar rhaffar commented Oct 17, 2024

Small QoL change - sometimes its not immediately obvious which columns in the join_columns are not in the compared dataframes (especially if upper-casing/lower-casing is involved). This should make it more obvious.

Copy link
Member

@fdosani fdosani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdosani fdosani merged commit 1078a82 into capitalone:develop Oct 17, 2024
30 checks passed
@fdosani fdosani mentioned this pull request Oct 23, 2024
fdosani added a commit that referenced this pull request Oct 24, 2024
* fixes #334 (#338)

* add diff for join columns (#339)

* Numpy 2.0 support and edgetest bumps (#328)

* fix for numpy 2.0 support

* version bump to 0.13.3

* updating testing matrix

* updating testing matrix

* updating testing matrix

* updating docs and adding in pytest skips for py3.12

* updating matrix to include 3.12

---------

Co-authored-by: rhaffar <[email protected]>
@fdosani fdosani mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants