Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique column name summary display #338

Merged
merged 1 commit into from
Oct 16, 2024
Merged

unique column name summary display #338

merged 1 commit into from
Oct 16, 2024

Conversation

fdosani
Copy link
Member

@fdosani fdosani commented Oct 16, 2024

update to the column_summary.txt rendering so number of unique column count and names gets displayed.

fixes #334

Copy link
Contributor

@gladysteh99 gladysteh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Minor thoughts: can probably add tests in the future to check the printed output

@fdosani fdosani merged commit 67d0fa2 into develop Oct 16, 2024
31 checks passed
@fdosani fdosani deleted the col-name-summary branch October 16, 2024 20:13
@fdosani fdosani mentioned this pull request Oct 23, 2024
fdosani added a commit that referenced this pull request Oct 24, 2024
* fixes #334 (#338)

* add diff for join columns (#339)

* Numpy 2.0 support and edgetest bumps (#328)

* fix for numpy 2.0 support

* version bump to 0.13.3

* updating testing matrix

* updating testing matrix

* updating testing matrix

* updating docs and adding in pytest skips for py3.12

* updating matrix to include 3.12

---------

Co-authored-by: rhaffar <[email protected]>
@fdosani fdosani mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add column names to column summary
2 participants