Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS range syntax to breakpoints settings page #5395

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mcslayer
Copy link
Contributor

@mcslayer mcslayer commented Oct 22, 2024

Done

Updated breakpoints settings page to use new CSS range syntax, based on conversation in #5287

Fixes #5394

QA

  • Open breakpoint-settings page

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshot

Screenshot 2024-10-22 at 10 12 33

@webteam-app
Copy link

mcslayer is not a collaborator of the repo

@bartaz
Copy link
Member

bartaz commented Oct 22, 2024

@bartaz
Copy link
Member

bartaz commented Oct 22, 2024

Thanks @mcslayer. Just a small suggestion for future PRs: when you are mentioning issues that PR fixes add Fixes before the issue id. Only this way GH will automatically close the issue when PR is merged. I fixed that here in the description.

@bartaz bartaz added Review: Code +1 Documentation 📝 Documentation changes or updates Review: QA needed Review: Percy needed This PR needs a review of Percy for visual regressions labels Oct 22, 2024
@mcslayer
Copy link
Contributor Author

Oh, that's right. I applied this approach in the initial pull requests, but later concluded that it doesn't look very elegant. I apologize for the oversight and will be more careful moving forward.

@bartaz bartaz added Review: QA +1 Review: Percy +1 and removed Review: QA needed Review: Percy needed This PR needs a review of Percy for visual regressions labels Oct 22, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good.

@bartaz bartaz merged commit c7d7d8d into canonical:main Oct 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakpoints settings page does not use CSS range syntax
3 participants