Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoints settings page does not use CSS range syntax #5394

Closed
jmuzina opened this issue Oct 21, 2024 · 1 comment · Fixed by #5395
Closed

Breakpoints settings page does not use CSS range syntax #5394

jmuzina opened this issue Oct 21, 2024 · 1 comment · Fixed by #5395
Labels
Documentation 📝 Documentation changes or updates Good first issue 🔰

Comments

@jmuzina
Copy link
Member

jmuzina commented Oct 21, 2024

The breakpoints settings page does not use the CSS range syntax that we introduced recently, such as in this PR.

Someone who follows these instructions will create styling that does not respond well to devices with fractional scaling enabled.

The examples on this page should probably be updated to use the new CSS range syntax as introduced by #5316 and similar PRs.

For example:

@media screen and (max-width: $breakpoint-small - 1) {
  // css
}

Should be changed to

@media screen and (width < $breakpoint-small) {
  // css
}
@jmuzina jmuzina added Good first issue 🔰 Documentation 📝 Documentation changes or updates labels Oct 21, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-16073.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📝 Documentation changes or updates Good first issue 🔰
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant