Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component files to use CSS range syntax #5316

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Aug 20, 2024

Done

Fixes #5313
Fixes WD-14299

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@pastelcyborg pastelcyborg added Review: QA needed Review: Code needed Bug 🐛 Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 20, 2024
@pastelcyborg pastelcyborg marked this pull request as ready for review August 20, 2024 17:41
@pastelcyborg pastelcyborg merged commit 2e1b69c into canonical:main Aug 20, 2024
13 checks passed
@pastelcyborg pastelcyborg deleted the 5313-component-breakpoints-range-queries branch August 20, 2024 20:03
Copy link
Contributor

@advl advl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering whether the older pattern still living in other files of the codebase

@pastelcyborg
Copy link
Contributor Author

Wondering whether the older pattern still living in other files of the codebase

Not anymore - I submitted 3 PRs to update this pattern across all existing files, separated by category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update component files to use CSS range syntax
4 participants