Lunar 2023 04 03 #1632
Merged
Lunar 2023 04 03 #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LP: #2013079 Found during beta testing that the live session is joining, instead of the target. (cherry picked from commit cd6e691)
realm --install <target> requires system bind-mounts to work properly. (cherry picked from commit 37f3348)
Sometimes unmounting order matters. Let's take the defensive approach. (cherry picked from commit cda5a0f)
UDI snap ships the package, thus its data dir is part of the snap subiquity snap does not. This tries l-s-c data dir in the base system, outside of the snap and gives up if the dir does not exits. (cherry picked from commit 1105da2)
Adjusted to pick commit from ubuntu/lunar branch. Signed-off-by: Olivier Gayot <[email protected]> (cherry picked from commit 4c4ab16)
dbungert
approved these changes
Apr 3, 2023
CarlosNihelton
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: with the comment I added in snapcraft.yaml, I expect future cherry-picks adjusting the curtin revision to conflict. This is on purpose, we don't want to pull new revisions of curtin from master (this would potentially introduce new features). To fix the conflict, we need to find the relevant revision in ubuntu/lunar.