[Active Directory] Bind mounts in the joining context manager #1627
Conversation
realm --install <target> requires system bind-mounts to work properly.
|
What problem were you encountering when you were running this through curtin? If humanely possible I don't want new mount code. Can you tell me more about this |
Sure. This is more related to I couldn't reproduce the Without the bind-mounts, |
subiquity/server/ad_joiner.py
Outdated
| yield hostname_process | ||
| finally: | ||
| # Restoring the live session hostname. | ||
| hostname_process = run_command(['hostname', hostname_current]) | ||
| if hostname_process.returncode: | ||
| log.info("Failed to restore live session hostname") | ||
| for bind in binds: |
There was a problem hiding this comment.
| for bind in binds: | |
| for bind in reversed(binds): |
I think for the mounts your doing the order won't matter, but it does sometimes. Let's reverse the order in case we add more to the list later.
Sometimes unmounting order matters. Let's take the defensive approach.
This concludes LP: 2013079.
realm --install <target>requires system bind-mounts to work properly.