Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTBFS since google-glog v0.7.0 #3320

Closed
wants to merge 1 commit into from
Closed

FTBFS since google-glog v0.7.0 #3320

wants to merge 1 commit into from

Conversation

AlanGriffiths
Copy link
Collaborator

Fixes: #3318

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner April 5, 2024 10:12
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (60a4214) to head (0577f47).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   77.42%   77.41%   -0.01%     
==========================================
  Files        1074     1064      -10     
  Lines       68471    68072     -399     
==========================================
- Hits        53016    52701     -315     
+ Misses      15455    15371      -84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saviq Saviq mentioned this pull request Apr 5, 2024
Closed
RAOF
RAOF approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this works (I don't have glog 0.7.0 handy), but checking upstream they describe the pkg-config files as “undocumented and unsupported”, so maybe we want to do #3321 instead?

@AlanGriffiths
Copy link
Collaborator Author

Closing in favour of #3330

@AlanGriffiths AlanGriffiths deleted the google-glog-v0.7.0-compatibility branch April 12, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAOF RAOF RAOF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FTBFS since google-glog v0.7.0
2 participants
@AlanGriffiths @RAOF