Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS since google-glog v0.7.0 #3318

Closed
JamiKettunen opened this issue Apr 5, 2024 · 2 comments · Fixed by #3330
Closed

FTBFS since google-glog v0.7.0 #3318

JamiKettunen opened this issue Apr 5, 2024 · 2 comments · Fixed by #3330
Assignees
Labels
triaged Triage into JIRA to plan it in

Comments

@JamiKettunen
Copy link
Contributor

JamiKettunen commented Apr 5, 2024

Reproducible by building v2.16.4 on e.g. Arch Linux:

[ 98%] Building CXX object examples/mir_demo_server/CMakeFiles/mir_demo_server.dir/server_example_test_client.cpp.o    
In file included from .../mir/src/mir-2.16.4/examples/mir_demo_server/glog_logger.cpp:19:    
/usr/include/glog/logging.h:60:4: error: #error <glog/logging.h> was not included correctly. See the documention for how to consume the library.    
   60 | #  error <glog/logging.h> was not included correctly. See the documention for how to consume the library.    
      |    ^~~~~    
In file included from /usr/include/glog/logging.h:63:    
/usr/include/glog/flags.h:45:4: error: #error <glog/flags.h> was not included correctly. See the documention for how to consume the library.    
   45 | #  error <glog/flags.h> was not included correctly. See the documention for how to consume the library.    
      |    ^~~~~    
In file included from /usr/include/glog/logging.h:77:    
/usr/include/glog/log_severity.h:38:4: error: #error <glog/log_severity.h> was not included correctly. See the documention for how to consume the library.    
   38 | #  error <glog/log_severity.h> was not included correctly. See the documention for how to consume the library.    
      |    ^~~~~    
In file included from /usr/include/glog/logging.h:78:    
/usr/include/glog/vlog_is_on.h:71:4: error: #error <glog/vlog_is_on.h> was not included correctly. See the documention for how to consume the library.    
   71 | #  error <glog/vlog_is_on.h> was not included correctly. See the documention for how to consume the library.    
      |    ^~~~~
@Saviq
Copy link
Collaborator

Saviq commented Apr 5, 2024

Hi @JamiKettunen, can you confirm #3320 fixes this for you?

@Saviq
Copy link
Collaborator

Saviq commented Apr 5, 2024

Could you maybe contribute CI steps similar to what we have for Alpine and Fedora?
Ref.
https://github.com/canonical/mir/blob/main/spread.yaml
https://github.com/canonical/mir/tree/main/spread/build

@AlanGriffiths AlanGriffiths added the triaged Triage into JIRA to plan it in label Apr 5, 2024
RAOF added a commit that referenced this issue Apr 8, 2024
Upstream describe their pkg-config support as “Undocumented and untested”, and it
doesn't work for GLog 0.7.0.

Fixes: #3318
github-merge-queue bot pushed a commit that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Triage into JIRA to plan it in
Projects
None yet
3 participants