Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance) changed to better wording for selecting all instances in project #558

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Nov 24, 2023

Done

  • Updated wording in pagination control for bulk selecting all instances in a project
  • Fixes #552

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • On the instances page, select one instance and check the wording in the pagination control for selecting all instances
    • On the instances page, filter the instances first then perform the previous action.
    • In the snapshots tab for a single instance, select one snapshot and check wording in pagination control should say 'select all x snapshots in instance'

Screenshots

Screenshot from 2023-11-24 16-06-36

image

Screenshot from 2023-11-24 16-08-39

@webteam-app
Copy link

Demo starting at https://lxd-ui-558.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done :)

@mas-who mas-who force-pushed the fix-wording-to-select-all-instances branch from 8495ce0 to bbfc9fa Compare November 24, 2023 14:29
@mas-who mas-who force-pushed the fix-wording-to-select-all-instances branch from 660eb64 to 4824885 Compare November 24, 2023 15:00
@mas-who mas-who merged commit 77996df into main Nov 24, 2023
6 checks passed
@edlerd edlerd deleted the fix-wording-to-select-all-instances branch December 1, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select all N project instances
3 participants