Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all N project instances #552

Closed
tomponline opened this issue Nov 23, 2023 · 7 comments · Fixed by #558
Closed

Select all N project instances #552

tomponline opened this issue Nov 23, 2023 · 7 comments · Fixed by #558
Assignees

Comments

@tomponline
Copy link
Member

I wondered why this part says "Select all N project instances" rather than "Select all N instances", why was the word project added here?

Thanks
Screenshot 2023-11-23 at 13-18-31 10 21 203 5 LXD UI

@edlerd
Copy link
Collaborator

edlerd commented Nov 23, 2023

We wanted to avoid implying this is about all instances on this server. The instance list is in context of a project, so we mention "project instances". This seems especially important, when many instances are available.

Do you think this should just say "select all n instances" without the project mentioned?

@tomponline
Copy link
Member Author

Yeah you could say "select all n instances listed" perhaps to show its only selecting the ones being shown.

@edlerd
Copy link
Collaborator

edlerd commented Nov 23, 2023

Yeah you could say "select all n instances listed" perhaps to show its only selecting the ones being shown.

When multiple pages are available, you might see only part of the instances that are about to be selected.

@piperdeck
Copy link

When multiple pages are available, you might see only part of the instances that are about to be selected.

This was the primary factor in the wording of this prompt. There are several potential scopes of a "select all" action, and we wanted to be as unambiguous as possible. In this case, clicking the button will select all instances in this project, including instances not shown by the current pagination, but not including other instances on the server.

@piperdeck
Copy link

FWIW, I've done some user testing on this pagination and my users seemed to understand and be comfortable with what's going on

@tomponline
Copy link
Member Author

To me instances are inherently linked to a project so "project instances" == "instances" , so the word "project" is effectively redundant. If it said "instances in project x" that would be clearer in my view.

@piperdeck
Copy link

I see what you mean. That works for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants