Warn when Stache tokens are used at the top level #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmomberger-bitovi
requested review from
christopherjbaker and
phillipskevin
and removed request for
christopherjbaker
christopherjbaker
approved these changes
Sep 14, 2017
|
This isn't a problem if the template is in a component or partial right? And it's not about performance afaik. |
justinbmeyer
requested changes
Sep 15, 2017
|
Comments on the issue #202 explain why this PR isn't ready. Don't merge yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202, but this had to include the commits from #307 for #302 because it depended on the new warnings helpers.