Refactor dev warning tests to use can-test-helpers #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinbmeyer
previously requested changes
Sep 17, 2017
test/stache-test.js
Outdated
| @@ -18,6 +18,7 @@ var parser = require('can-view-parser'); | |||
| var nodeLists = require('can-view-nodelist'); | |||
| var canBatch = require('can-event/batch/batch'); | |||
| var makeDocument = require('can-vdom/make-document/make-document'); | |||
| var devHelpers = require('can-test-helpers/lib/dev'); | |||
There was a problem hiding this comment.
Why have this in a module? I think we should just put everything on the package.
There was a problem hiding this comment.
Which package? In can-util alongside js/dev/ or in can-stache? If you mean can-stache, we really need the test helpers to be available elsewhere as we have warnings and errors that are tested elsewhere in the app.
bmomberger-bitovi
dismissed
justinbmeyer’s stale review
Addressed the concerns. Please re-review.
phillipskevin
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #302