Skip to content

Base D-Bus tests on SubManFixture#3181

Merged
ptoscano merged 1 commit intomainfrom
mhorky/dbus-fixture
Dec 7, 2022
Merged

Base D-Bus tests on SubManFixture#3181
ptoscano merged 1 commit intomainfrom
mhorky/dbus-fixture

Conversation

@m-horky
Copy link
Contributor

@m-horky m-horky commented Dec 7, 2022

This ensures all the injections have been initiated. Without them, the tests may fail on attempts to write '/etc/pki/product' or similar root directories.

This ensures all the injections have been initiated. Without them, the
tests may fail on attempts to write '/etc/pki/product' or similar root
directories.
@cnsnyder cnsnyder requested review from a team and cnsnyder and removed request for a team December 7, 2022 16:37
Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Fixes some of the failures I get from time to time.

@ptoscano ptoscano merged commit a9134c7 into main Dec 7, 2022
@ptoscano ptoscano deleted the mhorky/dbus-fixture branch December 7, 2022 16:53
@ptoscano
Copy link
Contributor

Late note: while reviewing #3176 I noticed that, in this PR, there is no super() call done in this PR for setUpClass(), tearDownClass(), and tearDown(); can you please add them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants