[1.28] Make 1.28 tests work on Fedora 37#3176
Merged
ptoscano merged 14 commits intosubscription-manager-1.28from Dec 12, 2022
Merged
[1.28] Make 1.28 tests work on Fedora 37#3176ptoscano merged 14 commits intosubscription-manager-1.28from
ptoscano merged 14 commits intosubscription-manager-1.28from
Conversation
m-horky
force-pushed
the
mhorky/pytest-updates-1.28
branch
2 times, most recently
from
4b166b4 to
9821ea1
Compare
* Card ID: ENT-5533 Adapted from commit 2e5dd64 It was not possible to backport it completely, as the branches differ too much: - Tests have been reorganized and some directories have been renamed. - rhsmlib tests have been split into service and D-Bus tests - 1.28 branch does not have the 'sender' argument in D-Bus methods, so we do not need to mock it in here.
* Card ID: ENT-5533 Adapted from commit dff6d71
* Card ID: ENT-5533 Adapted from commit de9730e
Adapted from f368d69
* Card ID: ENT-5533 Adapted from commit 2472cfc
* Card ID: ENT-5533 Adapted from commit fec8833
* Card ID: ENT-5533 Adapted from commit eaac363
* Card ID: ENT-5533 Adapted from commit 5e4d77c
* Card ID: ENT-5533 Adapted from commit 521cf61
Adapted from commit 7324c28
Adapted from commit 24e47e4
The fixture mocks and prepares many injections. While this solution is kind of like using a flamethrower to make a single piece of popcorn, it does work and fixes the issue of trying to access '/etc/pki/product/' directly.
m-horky
force-pushed
the
mhorky/pytest-updates-1.28
branch
from
9821ea1 to
7f5f83f
Compare
ptoscano
approved these changes
Dec 12, 2022
Contributor
ptoscano
left a comment
ptoscano
left a comment
There was a problem hiding this comment.
Thanks! Lots of changes to go through, however it seems to me everything was covered. A possible followup change could be trying to remove the forking behaviour of pytest, hopefully it should work fine without it now.
The only CI failure is on rhel-8-7 and it's due to infra issues, so let's merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #3124, #3181, and partial backport of #3156 as well. As the code differs quite a bit, it was not possible to cherry-pick the changes.