Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: initial cleanup of tokenizers (metaschema-update) #399

Merged
merged 1 commit into from
Apr 11, 2023
Merged

refactor!: initial cleanup of tokenizers (metaschema-update) #399

merged 1 commit into from
Apr 11, 2023

Conversation

korikuzma
Copy link
Member

Initial work for #332 in metaschema-update branch. Cherry picked this commit

Notes:

  • Removed unused Tokenizer classes: GenePairTokenizer, ProteinAlternateTokenizer
  • Removed NucleotideCache class. Moved base_nucleotides to Tokenizer class
  • Move TokenizerBase methods to Tokenizer
  • Instance vars --> class vars

@korikuzma
refactor!: initial cleanup of tokenizers (metaschema-update)
172ec4c 
- Removed unused Tokenizer classes: `GenePairTokenizer`, `ProteinAlternateTokenizer`
- Removed `NucleotideCache` class. Moved `base_nucleotides` to `Tokenizer` class
- Move `TokenizerBase` methods to `Tokenizer`
- Instance vars --> class vars
@korikuzma korikuzma added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Apr 10, 2023
@korikuzma korikuzma requested a review from jsstevenson April 10, 2023 19:41
@korikuzma korikuzma self-assigned this Apr 10, 2023
@korikuzma korikuzma merged commit 5d9bfc9 into staging Apr 11, 2023
@korikuzma korikuzma deleted the issue-332-initial-staging branch April 11, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korikuzma @jsstevenson