Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tokenizers #332

Closed
korikuzma opened this issue Sep 19, 2022 · 3 comments · Fixed by #474
Closed

Refactor tokenizers #332

korikuzma opened this issue Sep 19, 2022 · 3 comments · Fixed by #474
Assignees
@korikuzma
Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@korikuzma
Copy link
Member

I think we're inconsistent on how strings get tokenized. We should be consistent in using regex
@korikuzma korikuzma self-assigned this Sep 19, 2022
@korikuzma korikuzma added refactor priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" and removed refactor labels Dec 22, 2022
@korikuzma
Copy link
Member Author

korikuzma commented Apr 7, 2023 •
edited
Loading

Cleaning up tokenizer classes may help with #369

@korikuzma korikuzma changed the title Refactor tokenizer checks Refactor tokenizers Apr 7, 2023
This was referenced Apr 7, 2023
Merged
Merged
@korikuzma korikuzma reopened this May 10, 2023
@korikuzma
Copy link
Member Author

I don't think we need to worry about validating HGVS in the tokenize class

@korikuzma korikuzma mentioned this issue Jul 27, 2023
Merged
@korikuzma korikuzma linked a pull request Jul 29, 2023 that will close this issue
refactor!: clean up app #474
Merged
@korikuzma korikuzma mentioned this issue Aug 21, 2023
Merged
@github-actions
Copy link

Closed by #494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: clean up app cancervariants/variation-normalization
1 participant
@korikuzma