Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: initial cleanup of tokenizers #395

Merged
merged 8 commits into from
Apr 10, 2023
Merged

refactor!: initial cleanup of tokenizers #395

merged 8 commits into from
Apr 10, 2023

Conversation

korikuzma
Copy link
Member

Initial work for #332 . There's still A LOT of clean up left to do with tokenizers, but I will save this for a later time.

Notes:

  • Removed unused Tokenizer classes: GenePairTokenizer, ProteinAlternateTokenizer
  • Removed NucleotideCache class. Moved base_nucleotides to Tokenizer class
  • Move TokenizerBase methods to Tokenizer
  • Instance vars --> class vars

@korikuzma korikuzma added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Apr 7, 2023
@korikuzma korikuzma requested a review from jsstevenson April 7, 2023 13:45
@korikuzma korikuzma self-assigned this Apr 7, 2023
jsstevenson
jsstevenson approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean!

@korikuzma
Copy link
Member Author

@jsstevenson It feels so good slowly cleaning up this mess 😅

@korikuzma korikuzma merged commit 9f23878 into main Apr 10, 2023
@korikuzma korikuzma deleted the issue-332-initial-work branch April 10, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korikuzma @jsstevenson