refactor: extract reassure-danger package

[ShaswatPrabhat]

Aim: To extract reassure-danger to a separate package

Link for the issue can be found here

[changeset-bot]

🦋 Changeset detected

Latest commit: 8ff650a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@callstack/reassure-danger	Minor
reassure	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ShaswatPrabhat]

Above is failing Run danger.js with the error Cannot find module './lib/commonjs/plugin'
I had deleted the plugins file from reassure package for this change. So that dangerFile.ts could pick up directly from the new reassure-danger package.

I think I might have missed something. Please guide.

[mdjastrzebski]

Danger.js step fails due to following error:

Seems like we need to update dangerfile with correct import path.

[mdjastrzebski]

Seems like running yarn turbo run build as part of reassure-tests.sh fixed the issue. But I can no longer see danger output, so were still missing something.

I guess we can also rollback version updates, in favour of changesets.

[ShaswatPrabhat]

It is still waiting for one check to complete. Do we still need to make a change to reassure-tests.sh ?

[mdjastrzebski]

I've exacted the reassure-tests.sh script update and merged it as separate PR to main so that now it's no longer in this PR.

[ShaswatPrabhat]

Okay,
For reasure-danger package extraction, are there any other code changes to be done ?

[mdjastrzebski]

@ShaswatPrabhat For some reason the Danger step is not working properly, as there is no Danger report in this PR. We need to sort this out before merging.

[ShaswatPrabhat]

The Run danger.js command gives:

Found only messages, passing those to review. Request failed [403]: https://api.github.com/repos/callstack/reassure/issues/118/comments Response: { Feedback: undefined "message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/reference/issues#create-an-issue-comment" }

Seems to be a permission issue. But comparing with some other Action runs danger is able to create a comment successfully.

[mdjastrzebski]

@ShaswatPrabhat yes, this seems to be the error that is blocking us right now. I've checked and previous successful builds, did not have this. The error does not really make sense, maybe there is a "deeper" error that is trigger this error but not build displayed. Is it possible to run Danger on local machine to avoid long CI feedback loop>

[ShaswatPrabhat]

I tried to replicate the issue locally but wasn't able to, Found this issue though. Mine is a PR from fork as well. Hence wondering if that might be the issue. Also found a possible resolution here, but not sure if that is an acceptable one.

[mdjastrzebski]

@ShaswatPrabhat I've found the root cause why do not see the perf report for your PR. It is due to GITHUB_TOKEN not being allowed for forked repos. I've published the same PR but on main repo and there is a correct perf report: #133.

[ShaswatPrabhat]

Thank you very much @mdjastrzebski 👍🏼
Seems this will be an issue for most non-core contributors. But I also see we have an open issue to move away from DangerJS fully. Hopefully that would help.

[mdjastrzebski]

I am thinking about way the users should import danger plugin:

Option A: import from danger plugin package

// in dangerfile.ts
import reassure from '@callstack/danger-plugin-reassure'

That way we could make root package not include danger-plugin-reassure package, but users would have to add it to their package.json in addition to reassure root package.

Option B: import directly from root package

// in dangerfile.ts
import { dangerReassure } from 'reassure'

Which is good for now, but in the future Danger will not be our only CI integration method.

@thymikee wdyt about these? Maybe you got some other approach?

[mdjastrzebski]

Looks good. @thymikee please also take a look as I've messed a lot with this PR, so a fresh eye could spot new things.