perf: Optimize i18n instance caching in App Router #18309

hbjORbj · 2024-12-20T20:54:28Z

What does this PR do?

Added module-level caching for i18n instances to prevent unnecessary recreation
Confirmed that there's no instance of getFixedT util

This change improves translation loading performance by reusing i18n instances across requests while maintaining the same functionality.
Before: Each translation request would create a new i18n instance
After: i18n instances are cached and reused based on locale-namespace combinations

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Please use the latest Vercel preview and test please 🙏.

vercel · 2024-12-20T20:54:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Dec 23, 2024 4:55pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Dec 23, 2024 4:55pm

graphite-app · 2024-12-20T20:55:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-12-20T21:38:31Z

E2E results are ready!

Workflow #42263.1 latest results

eunjae-lee · 2024-12-23T09:45:03Z

apps/web/app/_utils.tsx

@@ -44,31 +55,21 @@ export const _generateMetadata = async (
  const h = headers();
  const canonical = h.get("x-pathname") ?? "";
  const locale = h.get("x-locale") ?? "en";
-
-  const t = await getFixedT(locale, "common");
+  const t = await getTranslationWithCache(locale);


NIT: we could even replace this with getTranslate()

eunjae-lee · 2024-12-23T09:48:14Z

@hbjORbj no preview available 🤔

(the code change looks good, but i haven't tested it yet)

…ance

* plain custom desin * No display on card * dynamic plain chat component and hmac hash * re-route users to plain.com chat instead of intercom chat when going to /support * provider errors * yarn lock fix * plain chat removed unneeded hmac * fix ts error * error handling improved * remove intercome provider from app-dir * Create getting-started.mdx (#18342) * Delete help directory (#18343) * chore: moved docs/help to /help (#18345) * chore: Delete unused guides directory (#18346) * feat: booking filters (#18303) Co-authored-by: Syed Ali Shahbaz <[email protected]> * chore: Remove `HeadSeo` components where no longer needed + improve app router metadata logic (#18348) * remove HeadSeo for already migrated pages and refactor prepareMetadata * create _generateMetadataWithoutImage and refactor _generateMetadata * chore: app router - /bookings status page (#18183) * chore: app router - /bookings page * remove env vars * fix * Update middleware.ts * revert unneeded change * refactor for the better * fix * cache i18n instances (#18309) * feat: virtual queues tab in insights (#18260) Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Omar López <[email protected]> * feat: update translations via @replexica (#18361) Co-authored-by: Replexica <[email protected]> * update OOO e2e tests to remove flakiness (#18367) * fix: metadata is overwritten for child managed eventType when updating parent (#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error * chore: added routing support link (#18369) * Added routing form support link * small change * Type fix --------- Co-authored-by: Joe Au-Yeung <[email protected]> * chore: refactor handling logic for embeds in app router (#18362) * refactor handling logic for embeds in app router * fix type checks * add test for withEmbedSsrAppDir * fix * review changes * yarn lock --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Calcom Bot <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Syed Ali Shahbaz <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Omar López <[email protected]> Co-authored-by: Replexica <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Alex van Andel <[email protected]>

* plain custom desin * No display on card * dynamic plain chat component and hmac hash * re-route users to plain.com chat instead of intercom chat when going to /support * provider errors * yarn lock fix * plain chat removed unneeded hmac * fix ts error * error handling improved * remove intercome provider from app-dir * Create getting-started.mdx (calcom#18342) * Delete help directory (calcom#18343) * chore: moved docs/help to /help (calcom#18345) * chore: Delete unused guides directory (calcom#18346) * feat: booking filters (calcom#18303) Co-authored-by: Syed Ali Shahbaz <[email protected]> * chore: Remove `HeadSeo` components where no longer needed + improve app router metadata logic (calcom#18348) * remove HeadSeo for already migrated pages and refactor prepareMetadata * create _generateMetadataWithoutImage and refactor _generateMetadata * chore: app router - /bookings status page (calcom#18183) * chore: app router - /bookings page * remove env vars * fix * Update middleware.ts * revert unneeded change * refactor for the better * fix * cache i18n instances (calcom#18309) * feat: virtual queues tab in insights (calcom#18260) Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Omar López <[email protected]> * feat: update translations via @replexica (calcom#18361) Co-authored-by: Replexica <[email protected]> * update OOO e2e tests to remove flakiness (calcom#18367) * fix: metadata is overwritten for child managed eventType when updating parent (calcom#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error * chore: added routing support link (calcom#18369) * Added routing form support link * small change * Type fix --------- Co-authored-by: Joe Au-Yeung <[email protected]> * chore: refactor handling logic for embeds in app router (calcom#18362) * refactor handling logic for embeds in app router * fix type checks * add test for withEmbedSsrAppDir * fix * review changes * yarn lock --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Calcom Bot <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Syed Ali Shahbaz <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Omar López <[email protected]> Co-authored-by: Replexica <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Alex van Andel <[email protected]>

cache i18n instances

bc6ab1c

graphite-app bot requested a review from a team December 20, 2024 20:54

dosubot bot added the i18n area: i18n, translations label Dec 20, 2024

keithwillcode added consumer core area: core, team members only labels Dec 20, 2024

hbjORbj changed the title ~~chore: cache i18n instance~~ chore: Optimize i18n instance caching in App Router Dec 20, 2024

hbjORbj changed the title ~~chore: Optimize i18n instance caching in App Router~~ perf: Optimize i18n instance caching in App Router Dec 20, 2024

hbjORbj enabled auto-merge (squash) December 20, 2024 20:58

hbjORbj added ready-for-e2e performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive labels Dec 20, 2024

vercel bot deployed to Preview – api December 20, 2024 21:01 View deployment

hbjORbj added ready-for-e2e and removed ready-for-e2e labels Dec 20, 2024

eunjae-lee reviewed Dec 23, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into chore/cache-i18n-inst…

37b7ea9

…ance

zomars approved these changes Dec 23, 2024

View reviewed changes

vercel bot deployed to Preview – api December 23, 2024 17:03 View deployment

hbjORbj merged commit 5fe4e09 into main Dec 23, 2024
38 checks passed

hbjORbj deleted the chore/cache-i18n-instance branch December 23, 2024 17:14

nizzyabi pushed a commit that referenced this pull request Dec 26, 2024

cache i18n instances (#18309)

4810649

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025

cache i18n instances (calcom#18309)

8b99252

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025

cache i18n instances (calcom#18309)

3e0465a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: Optimize i18n instance caching in App Router #18309

perf: Optimize i18n instance caching in App Router #18309

hbjORbj commented Dec 20, 2024 •

edited

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024

github-actions bot commented Dec 20, 2024 •

edited

Loading

eunjae-lee Dec 23, 2024

eunjae-lee commented Dec 23, 2024 •

edited

Loading

perf: Optimize i18n instance caching in App Router #18309

perf: Optimize i18n instance caching in App Router #18309

Conversation

hbjORbj commented Dec 20, 2024 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

vercel bot commented Dec 20, 2024 • edited Loading

graphite-app bot commented Dec 20, 2024

Graphite Automations

github-actions bot commented Dec 20, 2024 • edited Loading

E2E results are ready!

eunjae-lee Dec 23, 2024

Choose a reason for hiding this comment

eunjae-lee commented Dec 23, 2024 • edited Loading

hbjORbj commented Dec 20, 2024 •

edited

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

eunjae-lee commented Dec 23, 2024 •

edited

Loading