fix: metadata is overwritten for child managed eventType when updating parent #18059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
event-types
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/08/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/24/24)1 label was added to this PR based on Keith Williams's automation. |
anikdhabal
commented
Dec 8, 2024
packages/features/ee/managed-event-types/lib/handleChildrenEventTypes.ts
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Udit-takkar
previously requested changes
Dec 13, 2024
E2E results are ready! |
nizzyabi
pushed a commit
that referenced
this pull request
Dec 26, 2024
…g parent (#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error
emrysal
added a commit
that referenced
this pull request
Dec 26, 2024
* plain custom desin * No display on card * dynamic plain chat component and hmac hash * re-route users to plain.com chat instead of intercom chat when going to /support * provider errors * yarn lock fix * plain chat removed unneeded hmac * fix ts error * error handling improved * remove intercome provider from app-dir * Create getting-started.mdx (#18342) * Delete help directory (#18343) * chore: moved docs/help to /help (#18345) * chore: Delete unused guides directory (#18346) * feat: booking filters (#18303) Co-authored-by: Syed Ali Shahbaz <[email protected]> * chore: Remove `HeadSeo` components where no longer needed + improve app router metadata logic (#18348) * remove HeadSeo for already migrated pages and refactor prepareMetadata * create _generateMetadataWithoutImage and refactor _generateMetadata * chore: app router - /bookings status page (#18183) * chore: app router - /bookings page * remove env vars * fix * Update middleware.ts * revert unneeded change * refactor for the better * fix * cache i18n instances (#18309) * feat: virtual queues tab in insights (#18260) Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Omar López <[email protected]> * feat: update translations via @replexica (#18361) Co-authored-by: Replexica <[email protected]> * update OOO e2e tests to remove flakiness (#18367) * fix: metadata is overwritten for child managed eventType when updating parent (#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error * chore: added routing support link (#18369) * Added routing form support link * small change * Type fix --------- Co-authored-by: Joe Au-Yeung <[email protected]> * chore: refactor handling logic for embeds in app router (#18362) * refactor handling logic for embeds in app router * fix type checks * add test for withEmbedSsrAppDir * fix * review changes * yarn lock --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Calcom Bot <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Syed Ali Shahbaz <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Omar López <[email protected]> Co-authored-by: Replexica <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Alex van Andel <[email protected]>
joeauyeung
pushed a commit
that referenced
this pull request
Jan 5, 2025
…g parent (#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error
joeauyeung
added a commit
that referenced
this pull request
Jan 5, 2025
* plain custom desin * No display on card * dynamic plain chat component and hmac hash * re-route users to plain.com chat instead of intercom chat when going to /support * provider errors * yarn lock fix * plain chat removed unneeded hmac * fix ts error * error handling improved * remove intercome provider from app-dir * Create getting-started.mdx (#18342) * Delete help directory (#18343) * chore: moved docs/help to /help (#18345) * chore: Delete unused guides directory (#18346) * feat: booking filters (#18303) Co-authored-by: Syed Ali Shahbaz <[email protected]> * chore: Remove `HeadSeo` components where no longer needed + improve app router metadata logic (#18348) * remove HeadSeo for already migrated pages and refactor prepareMetadata * create _generateMetadataWithoutImage and refactor _generateMetadata * chore: app router - /bookings status page (#18183) * chore: app router - /bookings page * remove env vars * fix * Update middleware.ts * revert unneeded change * refactor for the better * fix * cache i18n instances (#18309) * feat: virtual queues tab in insights (#18260) Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Omar López <[email protected]> * feat: update translations via @replexica (#18361) Co-authored-by: Replexica <[email protected]> * update OOO e2e tests to remove flakiness (#18367) * fix: metadata is overwritten for child managed eventType when updating parent (#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error * chore: added routing support link (#18369) * Added routing form support link * small change * Type fix --------- Co-authored-by: Joe Au-Yeung <[email protected]> * chore: refactor handling logic for embeds in app router (#18362) * refactor handling logic for embeds in app router * fix type checks * add test for withEmbedSsrAppDir * fix * review changes * yarn lock --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Calcom Bot <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Syed Ali Shahbaz <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Omar López <[email protected]> Co-authored-by: Replexica <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Alex van Andel <[email protected]>
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
…g parent (calcom#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
* plain custom desin * No display on card * dynamic plain chat component and hmac hash * re-route users to plain.com chat instead of intercom chat when going to /support * provider errors * yarn lock fix * plain chat removed unneeded hmac * fix ts error * error handling improved * remove intercome provider from app-dir * Create getting-started.mdx (calcom#18342) * Delete help directory (calcom#18343) * chore: moved docs/help to /help (calcom#18345) * chore: Delete unused guides directory (calcom#18346) * feat: booking filters (calcom#18303) Co-authored-by: Syed Ali Shahbaz <[email protected]> * chore: Remove `HeadSeo` components where no longer needed + improve app router metadata logic (calcom#18348) * remove HeadSeo for already migrated pages and refactor prepareMetadata * create _generateMetadataWithoutImage and refactor _generateMetadata * chore: app router - /bookings status page (calcom#18183) * chore: app router - /bookings page * remove env vars * fix * Update middleware.ts * revert unneeded change * refactor for the better * fix * cache i18n instances (calcom#18309) * feat: virtual queues tab in insights (calcom#18260) Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Omar López <[email protected]> * feat: update translations via @replexica (calcom#18361) Co-authored-by: Replexica <[email protected]> * update OOO e2e tests to remove flakiness (calcom#18367) * fix: metadata is overwritten for child managed eventType when updating parent (calcom#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error * chore: added routing support link (calcom#18369) * Added routing form support link * small change * Type fix --------- Co-authored-by: Joe Au-Yeung <[email protected]> * chore: refactor handling logic for embeds in app router (calcom#18362) * refactor handling logic for embeds in app router * fix type checks * add test for withEmbedSsrAppDir * fix * review changes * yarn lock --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Calcom Bot <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Syed Ali Shahbaz <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Omar López <[email protected]> Co-authored-by: Replexica <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Alex van Andel <[email protected]>
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 20, 2025
…g parent (calcom#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 20, 2025
* plain custom desin * No display on card * dynamic plain chat component and hmac hash * re-route users to plain.com chat instead of intercom chat when going to /support * provider errors * yarn lock fix * plain chat removed unneeded hmac * fix ts error * error handling improved * remove intercome provider from app-dir * Create getting-started.mdx (calcom#18342) * Delete help directory (calcom#18343) * chore: moved docs/help to /help (calcom#18345) * chore: Delete unused guides directory (calcom#18346) * feat: booking filters (calcom#18303) Co-authored-by: Syed Ali Shahbaz <[email protected]> * chore: Remove `HeadSeo` components where no longer needed + improve app router metadata logic (calcom#18348) * remove HeadSeo for already migrated pages and refactor prepareMetadata * create _generateMetadataWithoutImage and refactor _generateMetadata * chore: app router - /bookings status page (calcom#18183) * chore: app router - /bookings page * remove env vars * fix * Update middleware.ts * revert unneeded change * refactor for the better * fix * cache i18n instances (calcom#18309) * feat: virtual queues tab in insights (calcom#18260) Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Omar López <[email protected]> * feat: update translations via @replexica (calcom#18361) Co-authored-by: Replexica <[email protected]> * update OOO e2e tests to remove flakiness (calcom#18367) * fix: metadata is overwritten for child managed eventType when updating parent (calcom#18059) * fix: metadata is overwirten * Update * type error * Update * fix test * fix type error * chore: added routing support link (calcom#18369) * Added routing form support link * small change * Type fix --------- Co-authored-by: Joe Au-Yeung <[email protected]> * chore: refactor handling logic for embeds in app router (calcom#18362) * refactor handling logic for embeds in app router * fix type checks * add test for withEmbedSsrAppDir * fix * review changes * yarn lock --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Calcom Bot <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Syed Ali Shahbaz <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: Omar López <[email protected]> Co-authored-by: Replexica <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Alex van Andel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
More Context:- https://app.campsite.com/cal/posts/z7n1o8dexajx#comment-wvo37qrhchc6