Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-435) Don't throw exception if not running in PR build #436

Merged
merged 1 commit into from
Oct 11, 2023
Merged

(GH-435) Don't throw exception if not running in PR build #436

merged 1 commit into from
Oct 11, 2023

Conversation

pascalberger
Copy link
Member

@pascalberger pascalberger commented Oct 11, 2023 •
edited
Loading

Don't throw an exception in AzureDevOpsPullRequestUsingAzurePipelinesOAuthToken if not running in an Azure Pipelines pull request build if throwException is set to false.

The parameter throwExceptionIfPullRequestCouldNotBeFound has been renamed to throwException to make it more obvious that it will also handle exceptions if Azure Pipelines variables are not available.

Fixes #435

@pascalberger pascalberger enabled auto-merge (squash) October 11, 2023 19:44
@pascalberger pascalberger merged commit 98631a2 into cake-contrib:develop Oct 11, 2023
16 checks passed
@pascalberger pascalberger deleted the feature/consider-param-if-no-pr-build branch October 11, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AzureDevOpsPullRequestUsingAzurePipelinesOAuthToken throws exception if not running pull request build
1 participant
@pascalberger