Skip to content

Eliminators for tagged heap objects#273

Merged
ggreif merged 4 commits intomasterfrom
gabor/tagged-switch
Mar 26, 2019
Merged

Eliminators for tagged heap objects#273
ggreif merged 4 commits intomasterfrom
gabor/tagged-switch

Conversation

@ggreif
Copy link
Copy Markdown
Contributor

@ggreif ggreif commented Mar 26, 2019

This is one of the open suggestions from #197 and formerly discussed there.

ggreif
ggreif commented Mar 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early remarks. Not sure whether this whole thing carries enough water.

nomeata
nomeata reviewed Mar 26, 2019
View reviewed changes
ggreif added 2 commits March 26, 2019 16:12
@ggreif
review feedback, bugfix
cfb9a6c
@ggreif
refine the ideas
424f82d 
branch_default --> tag may be not covered, needs default
branch --> known tag
_branch_default_with --> each leg also has the TOS, tag may be not covered, needs default
branch_with --> each leg also has the TOS, known tag
@ggreif ggreif marked this pull request as ready for review March 26, 2019 20:50
@ggreif ggreif requested a review from nomeata March 26, 2019 20:50
@ggreif ggreif changed the title suggestion for eliminators Eliminators for tagged heap objects Mar 26, 2019
nomeata
nomeata approved these changes Mar 26, 2019
View reviewed changes
src/compile.ml Outdated
@@ -4039,16 +4058,12 @@ and compile_exp (env : E.t) exp =
SR.Vanilla,
compile_exp_vanilla env e ^^
begin
Copy link
Copy Markdown
Contributor

@nomeata nomeata Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit: Remove the begin… end (no longer needed as there is no longer a match here.

@nomeata
Copy link
Copy Markdown
Contributor

nomeata commented Mar 26, 2019

And I suggest to squash this.

@ggreif ggreif merged commit 885e107 into master Mar 26, 2019
@nomeata nomeata deleted the gabor/tagged-switch branch April 2, 2019 15:28
dfinity-bot added a commit that referenced this pull request Sep 18, 2020
@dfinity-bot
niv common: update d8396f46 -> 86dcb573
f3188b5 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@d8396f46...86dcb573](https://github.com/dfinity-lab/common/compare/d8396f46fac5dc59a657a17e6e52898d9bf0797f...86dcb57316afd19cd07cd7da8142e60e1713f4ee)

* [`abffb600`](https://github.com/dfinity-lab/common/commit/abffb60072633f0c7fd4c4880196c819bb01c159) add ssh pk ([dfinity-lab/common⁠#273](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/273))
* [`f550021d`](https://github.com/dfinity-lab/common/commit/f550021df8697aa29c9ad71dc1220f4a3bfa09b9) adding ssh key for Hassen
* [`f1f7f69a`](https://github.com/dfinity-lab/common/commit/f1f7f69a65aa03aabc334663b066ca723dec1c28) formatting
* [`cd7f0b51`](https://github.com/dfinity-lab/common/commit/cd7f0b51f893344ed974f1b3bbd47fd3bc24d16d) fix email address
* [`25b1d9f4`](https://github.com/dfinity-lab/common/commit/25b1d9f4ce2040d7bebd0a7a6fd172720b6b1559) run nix-fmt
* [`c5fe2afa`](https://github.com/dfinity-lab/common/commit/c5fe2afacad8a09d1318f1b87a6aa057d2eadeee) Update ssh key for Khushboo
* [`00a59776`](https://github.com/dfinity-lab/common/commit/00a59776062f35e64d1527bcc8165a6c16039090) Add Stavros to authorized keys
* [`aff78c26`](https://github.com/dfinity-lab/common/commit/aff78c262d7415d9d07f41a6b3be0d6d315e881e) niv niv: update dd13098d -> 29ddaaf4
* [`5a552545`](https://github.com/dfinity-lab/common/commit/5a552545638885aaf1333d22b94199be97309a84) add some more metadata debugging information for macos
mergify bot pushed a commit that referenced this pull request Sep 18, 2020
@dfinity-bot
niv common: update d8396f46 -> 86dcb573 (#1948)
11ef16a 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@d8396f46...86dcb573](https://github.com/dfinity-lab/common/compare/d8396f46fac5dc59a657a17e6e52898d9bf0797f...86dcb57316afd19cd07cd7da8142e60e1713f4ee)

* [`abffb600`](https://github.com/dfinity-lab/common/commit/abffb60072633f0c7fd4c4880196c819bb01c159) add ssh pk ([dfinity-lab/common⁠#273](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/273))
* [`f550021d`](https://github.com/dfinity-lab/common/commit/f550021df8697aa29c9ad71dc1220f4a3bfa09b9) adding ssh key for Hassen
* [`f1f7f69a`](https://github.com/dfinity-lab/common/commit/f1f7f69a65aa03aabc334663b066ca723dec1c28) formatting
* [`cd7f0b51`](https://github.com/dfinity-lab/common/commit/cd7f0b51f893344ed974f1b3bbd47fd3bc24d16d) fix email address
* [`25b1d9f4`](https://github.com/dfinity-lab/common/commit/25b1d9f4ce2040d7bebd0a7a6fd172720b6b1559) run nix-fmt
* [`c5fe2afa`](https://github.com/dfinity-lab/common/commit/c5fe2afacad8a09d1318f1b87a6aa057d2eadeee) Update ssh key for Khushboo
* [`00a59776`](https://github.com/dfinity-lab/common/commit/00a59776062f35e64d1527bcc8165a6c16039090) Add Stavros to authorized keys
* [`aff78c26`](https://github.com/dfinity-lab/common/commit/aff78c262d7415d9d07f41a6b3be0d6d315e881e) niv niv: update dd13098d -> 29ddaaf4
* [`5a552545`](https://github.com/dfinity-lab/common/commit/5a552545638885aaf1333d22b94199be97309a84) add some more metadata debugging information for macos
dfinity-bot added a commit that referenced this pull request Feb 2, 2021
@dfinity-bot
niv ic-ref: update 3716b934 -> 37a24d1d
b01ed65 
## Changelog for ic-ref:
Branch: release-0.15
Commits: [dfinity-lab/ic-ref@3716b934...37a24d1d](https://github.com/dfinity-lab/ic-ref/compare/3716b934e8699aea3423535fc69c0f6b077ba842...37a24d1d20be2ed27aeed5b0d1b1c567411447e5)

* [`bb8b29ab`](https://github.com/dfinity-lab/ic-ref/commit/bb8b29abf6f67fc8d33a0a35c93d0effc358e9e4) Public Spec: minor edits ([dfinity-lab/ic-ref⁠#256](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/256))
* [`88d3431d`](https://github.com/dfinity-lab/ic-ref/commit/88d3431d531fb78df4a2eef200908083a0a53322) Public Spec: Typo ([dfinity-lab/ic-ref⁠#271](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/271))
* [`988172f0`](https://github.com/dfinity-lab/ic-ref/commit/988172f01c0340ef576f79c69436218a17813d02) Remove .mergify
* [`72d26869`](https://github.com/dfinity-lab/ic-ref/commit/72d268693d4a67b84ba0e7f53914892dadd317d7) ic-ref-test: Implement Webauthn signing natively ([dfinity-lab/ic-ref⁠#272](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/272))
* [`37a24d1d`](https://github.com/dfinity-lab/ic-ref/commit/37a24d1d20be2ed27aeed5b0d1b1c567411447e5) ic-ref-test: support --xml for a JUnit report ([dfinity-lab/ic-ref⁠#273](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/273))
mergify bot pushed a commit that referenced this pull request Feb 2, 2021
@dfinity-bot
niv ic-ref: update 3716b934 -> 37a24d1d (#2306)
6d88c34 
## Changelog for ic-ref:
Branch: release-0.15
Commits: [dfinity-lab/ic-ref@3716b934...37a24d1d](https://github.com/dfinity-lab/ic-ref/compare/3716b934e8699aea3423535fc69c0f6b077ba842...37a24d1d20be2ed27aeed5b0d1b1c567411447e5)

* [`bb8b29ab`](https://github.com/dfinity-lab/ic-ref/commit/bb8b29abf6f67fc8d33a0a35c93d0effc358e9e4) Public Spec: minor edits ([dfinity-lab/ic-ref⁠#256](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/256))
* [`88d3431d`](https://github.com/dfinity-lab/ic-ref/commit/88d3431d531fb78df4a2eef200908083a0a53322) Public Spec: Typo ([dfinity-lab/ic-ref⁠#271](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/271))
* [`988172f0`](https://github.com/dfinity-lab/ic-ref/commit/988172f01c0340ef576f79c69436218a17813d02) Remove .mergify
* [`72d26869`](https://github.com/dfinity-lab/ic-ref/commit/72d268693d4a67b84ba0e7f53914892dadd317d7) ic-ref-test: Implement Webauthn signing natively ([dfinity-lab/ic-ref⁠#272](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/272))
* [`37a24d1d`](https://github.com/dfinity-lab/ic-ref/commit/37a24d1d20be2ed27aeed5b0d1b1c567411447e5) ic-ref-test: support --xml for a JUnit report ([dfinity-lab/ic-ref⁠#273](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/273))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nomeata nomeata nomeata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggreif @nomeata