Conversation
ggreif
approved these changes
Mar 26, 2019
Contributor
ggreif
left a comment
ggreif
left a comment
There was a problem hiding this comment.
Looks reasonable. But maybe we can wait for a landed https://github.com/dfinity-lab/dev/pull/697?
Contributor
Author
|
We can update |
nomeata
force-pushed
the
joachim/dev-master
branch
from
6fcf5b9 to
31e7ab6
Compare
dfinity-bot
added a commit
that referenced
this pull request
Feb 2, 2021
## Changelog for ic-ref: Branch: release-0.15 Commits: [dfinity-lab/ic-ref@3716b934...37a24d1d](https://github.com/dfinity-lab/ic-ref/compare/3716b934e8699aea3423535fc69c0f6b077ba842...37a24d1d20be2ed27aeed5b0d1b1c567411447e5) * [`bb8b29ab`](https://github.com/dfinity-lab/ic-ref/commit/bb8b29abf6f67fc8d33a0a35c93d0effc358e9e4) Public Spec: minor edits ([dfinity-lab/ic-ref#256](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/256)) * [`88d3431d`](https://github.com/dfinity-lab/ic-ref/commit/88d3431d531fb78df4a2eef200908083a0a53322) Public Spec: Typo ([dfinity-lab/ic-ref#271](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/271)) * [`988172f0`](https://github.com/dfinity-lab/ic-ref/commit/988172f01c0340ef576f79c69436218a17813d02) Remove .mergify * [`72d26869`](https://github.com/dfinity-lab/ic-ref/commit/72d268693d4a67b84ba0e7f53914892dadd317d7) ic-ref-test: Implement Webauthn signing natively ([dfinity-lab/ic-ref#272](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/272)) * [`37a24d1d`](https://github.com/dfinity-lab/ic-ref/commit/37a24d1d20be2ed27aeed5b0d1b1c567411447e5) ic-ref-test: support --xml for a JUnit report ([dfinity-lab/ic-ref#273](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/273))
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2021
## Changelog for ic-ref: Branch: release-0.15 Commits: [dfinity-lab/ic-ref@3716b934...37a24d1d](https://github.com/dfinity-lab/ic-ref/compare/3716b934e8699aea3423535fc69c0f6b077ba842...37a24d1d20be2ed27aeed5b0d1b1c567411447e5) * [`bb8b29ab`](https://github.com/dfinity-lab/ic-ref/commit/bb8b29abf6f67fc8d33a0a35c93d0effc358e9e4) Public Spec: minor edits ([dfinity-lab/ic-ref#256](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/256)) * [`88d3431d`](https://github.com/dfinity-lab/ic-ref/commit/88d3431d531fb78df4a2eef200908083a0a53322) Public Spec: Typo ([dfinity-lab/ic-ref#271](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/271)) * [`988172f0`](https://github.com/dfinity-lab/ic-ref/commit/988172f01c0340ef576f79c69436218a17813d02) Remove .mergify * [`72d26869`](https://github.com/dfinity-lab/ic-ref/commit/72d268693d4a67b84ba0e7f53914892dadd317d7) ic-ref-test: Implement Webauthn signing natively ([dfinity-lab/ic-ref#272](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/272)) * [`37a24d1d`](https://github.com/dfinity-lab/ic-ref/commit/37a24d1d20be2ed27aeed5b0d1b1c567411447e5) ic-ref-test: support --xml for a JUnit report ([dfinity-lab/ic-ref#273](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/ic-ref/issues/273))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.