Skip to content

Remove own default_uncaught_exception_handler #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jul 28, 2021
Merged

Remove own default_uncaught_exception_handler #2685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e340da0
remove own uncaught_exception_handler
ggreif Jul 28, 2021
67f2838
reduce noise
ggreif Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/mo_config/internal_error.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@

(* TODO: replace with Printexc.default_uncaught_exception_handler with OCaml 4.11*)
let default_uncaught_exception_handler exn raw_backtrace =
Printexc.(
Printf.eprintf "Fatal error: exception %s\n" (to_string exn);
print_raw_backtrace stderr raw_backtrace;
flush stderr)

let setup_handler () =
Printexc.record_backtrace true;
Printexc.set_uncaught_exception_handler (fun exn rb ->
let open Printexc in
record_backtrace true;
set_uncaught_exception_handler (fun exn rb ->
Printf.eprintf "OOPS! You've triggered a compiler bug.\n";
Printf.eprintf "Please report this at https://github.com/dfinity/motoko/issues/new with the following details:\n\nMotoko %s\n\n" Source_id.banner;
default_uncaught_exception_handler exn rb
Expand Down