Remove own default_uncaught_exception_handler#2685
Merged
mergify[bot] merged 2 commits intomasterfrom Jul 28, 2021
Merged
Conversation
we have OCaml 12 now, so Printexc provides it
|
This PR does not affect the produced WebAssembly code. |
Contributor
|
Does this change the error output in any way? |
Contributor
Author
No. But I so far haven't figured out how to get backtraces, so that's a point that remains to be clarified. |
Contributor
I think you need LGTM but if this changes the output it would be good to show before and after in the commit message. |
osa1
approved these changes
Jul 28, 2021
Contributor
Author
|
The function replacing ours is https://github.com/ocaml/ocaml/pull/9263/files#diff-5fa438e4a308c8dfd6c75768649ae4fe17b72159d89f5ae3e7319c8eeaf2b790R273 and looks exactly the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have OCaml 4.12 now, so
Printexcprovides it