Skip to content

Use int32_of_big_int when computing bignum limbs #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Jul 27, 2021
Merged

Use int32_of_big_int when computing bignum limbs #2682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/codegen/compile.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2497,7 +2497,7 @@ module BigNumLibtommath : BigNumType = struct
then []
else
let (a, b) = Big_int.quomod_big_int n twoto28 in
Copy link
Copy Markdown
Contributor

@chenyan-dfinity chenyan-dfinity Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why it's 28 bit here?

Copy link
Copy Markdown
Contributor Author

@ggreif ggreif Jul 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nomeata is this some MP/LibTomMath thing?

Copy link
Copy Markdown
Contributor

@nomeata nomeata Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the internal representation of libtommath bigints uses 28 bit limbs

[ Int32.of_int (Big_int.int_of_big_int b) ] @ go a
[ Big_int.int32_of_big_int b ] @ go a
in go n
in
(* how many 32 bit digits *)
Expand Down