Use int32_of_big_int when computing bignum limbs#2682
Merged
mergify[bot] merged 1 commit intomasterfrom Jul 27, 2021
Merged
Conversation
I suspect this will also resolve potential problems with trapping on 32-bit compilation platforms. I don't think it is related to #2671, but who knows?
|
This PR does not affect the produced WebAssembly code. |
chenyan-dfinity
approved these changes
Jul 27, 2021
| @@ -2497,7 +2497,7 @@ module BigNumLibtommath : BigNumType = struct | |||
| then [] | |||
| else | |||
| let (a, b) = Big_int.quomod_big_int n twoto28 in | |||
Contributor
There was a problem hiding this comment.
Curious why it's 28 bit here?
Contributor
Author
There was a problem hiding this comment.
@nomeata is this some MP/LibTomMath thing?
Contributor
There was a problem hiding this comment.
Yes, I think the internal representation of libtommath bigints uses 28 bit limbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect this will also resolve potential problems with trapping on 32-bit compilation platforms. I don't think it is related to #2671, but who knows?