Skip to content

Updated error message for empty input (#2665) #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 4 commits into from
Jul 20, 2021
Merged

Updated error message for empty input (#2665) #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63a97f4
Updated error message for empty input (#2665)
ehsan6sha Jul 20, 2021
3953790
Update issue-1847.drun-run.ok
ggreif Jul 20, 2021
582db97
Update issue-1847.ic-ref-run.ok
ggreif Jul 20, 2021
385c822
fmt
ggreif Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rts/motoko-rts/src/idl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ unsafe fn parse_idl_header<M: Memory>(
main_types_out: *mut *mut u8,
) {
if (*buf).ptr == (*buf).end {
idl_trap_with("empty input");
idl_trap_with(
"empty input. Expected Candid-encoded argument, but received a zero-length argument",
);
}

// Magic bytes (DIDL)
Expand Down
2 changes: 1 addition & 1 deletion test/run-drun/ok/issue-1847.drun-run.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
ingress Err: IC0503: Canister rwlgt-iiaaa-aaaaa-aaaaa-cai trapped explicitly: IDL error: empty input
ingress Err: IC0503: Canister rwlgt-iiaaa-aaaaa-aaaaa-cai trapped explicitly: IDL error: empty input. Expected Candid-encoded argument, but received a zero-length argument
2 changes: 1 addition & 1 deletion test/run-drun/ok/issue-1847.ic-ref-run.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
→ update create_canister(record {dnczaeh = null})
← replied: (record {hymijyo = principal "cvccv-qqaaq-aaaaa-aaaaa-c"})
→ update install_code(record {arg = blob ""; kca_xin = blob "\00asm\01\00\00\00\0…
← rejected (RC_CANISTER_ERROR): Initialization trapped: EvalTrapError region:0xXXX-0xXXX "canister trapped explicitly: IDL error: empty input"
← rejected (RC_CANISTER_ERROR): Initialization trapped: EvalTrapError region:0xXXX-0xXXX "canister trapped explicitly: IDL error: empty input. Expected Candid-encoded argument, but received a zero-length argument"