Skip to content

Comments

Updated error message for empty input (#2665)#2667

Merged
mergify[bot] merged 4 commits intomasterfrom
master-2665
Jul 20, 2021
Merged

Updated error message for empty input (#2665)#2667
mergify[bot] merged 4 commits intomasterfrom
master-2665

Conversation

@ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 20, 2021

Updated error message of empty input to be more explanatory per discussion below:
https://forum.dfinity.org/t/canister-xxx-trapped-explicitly-idl-error-empty-input/6002

@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Jul 20, 2021
@ggreif ggreif requested a review from chenyan-dfinity July 20, 2021 17:04
@ggreif
Copy link
Contributor Author

ggreif commented Jul 20, 2021

Fixes #2666

@ggreif
Copy link
Contributor Author

ggreif commented Jul 20, 2021

Thanks, @ehsan6sha! I added just a few more touchups for CI's satisfaction.

@mergify mergify bot merged commit 3b193bd into master Jul 20, 2021
@mergify mergify bot deleted the master-2665 branch July 20, 2021 17:23
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants