Skip to content

Bump dev to latest dev master#230

Closed
nomeata wants to merge 2 commits intomasterfrom
joachim/bump-dev
Closed

Bump dev to latest dev master#230
nomeata wants to merge 2 commits intomasterfrom
joachim/bump-dev

Conversation

@nomeata
Copy link
Copy Markdown
Contributor

@nomeata nomeata commented Mar 11, 2019

No description provided.

@ggreif
Copy link
Copy Markdown
Contributor

ggreif commented Mar 11, 2019

I see these discrepancies:

$ git diff
diff --git a/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok b/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok
index 4a1af3b..e6d1727 100644
--- a/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok
+++ b/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok
@@ -1,2 +1,3 @@
 W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
+W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
 Top-level code done.
diff --git a/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok b/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok
index 84cb71c..c8ab234 100644
--- a/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok
+++ b/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok
@@ -1,7 +1,6 @@
+Top-level code done.
 
-#
-# Fatal error in v8::ToLocalChecked
-# Empty MaybeLocal.
-#
-
-dvm.sh: line 14: Illegal instruction dvm $@
+first-order
+,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,
+higher-order
+,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,
diff --git a/test/run-dfinity/ok/overflow.dvm-run.ok b/test/run-dfinity/ok/overflow.dvm-run.ok
index 501d4e7..5db4566 100644
--- a/test/run-dfinity/ok/overflow.dvm-run.ok
+++ b/test/run-dfinity/ok/overflow.dvm-run.ok
@@ -1,4 +1,5 @@
 W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
+W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
 Top-level code done.
 This is reachable.
 This is reachable.

The last one perhaps explains the problem what we see with the original make parallel patch.

@ggreif
Copy link
Copy Markdown
Contributor

ggreif commented Mar 11, 2019

This is how I updated dev (which was already cloned in nix/dev)

git -C nix/dev fetch --recurse-submodules
git -C nix/dev checkout b338810dbba5a71aa4cfb59b85172a4e0caeac5e
git -C nix/dev submodule update --init --recursive

it seems that the V8 bug (https://dfinity.atlassian.net/browse/M1-513)
has gone away.
@nomeata
Copy link
Copy Markdown
Contributor Author

nomeata commented Mar 12, 2019

Ok, the new dev uses fetchgit and thus does not build in Jenkins the way it did before, it sees. So let’s put our hope into #227

@nomeata nomeata closed this Mar 15, 2019
@nomeata nomeata deleted the joachim/bump-dev branch March 15, 2019 13:38
dfinity-bot added a commit that referenced this pull request Mar 11, 2021
mergify bot pushed a commit that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants