Conversation
Contributor
|
I see these discrepancies: $ git diff
diff --git a/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok b/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok
index 4a1af3b..e6d1727 100644
--- a/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok
+++ b/test/run-dfinity/ok/array-out-of-bounds.dvm-run.ok
@@ -1,2 +1,3 @@
W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
+W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
Top-level code done.
diff --git a/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok b/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok
index 84cb71c..c8ab234 100644
--- a/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok
+++ b/test/run-dfinity/ok/flatten-awaitables.dvm-run.ok
@@ -1,7 +1,6 @@
+Top-level code done.
-#
-# Fatal error in v8::ToLocalChecked
-# Empty MaybeLocal.
-#
-
-dvm.sh: line 14: Illegal instruction dvm $@
+first-order
+,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,
+higher-order
+,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,
diff --git a/test/run-dfinity/ok/overflow.dvm-run.ok b/test/run-dfinity/ok/overflow.dvm-run.ok
index 501d4e7..5db4566 100644
--- a/test/run-dfinity/ok/overflow.dvm-run.ok
+++ b/test/run-dfinity/ok/overflow.dvm-run.ok
@@ -1,4 +1,5 @@
W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
+W, hypervisor: call failed with trap message: Uncaught RuntimeError: unreachable
Top-level code done.
This is reachable.
This is reachable.The last one perhaps explains the problem what we see with the original |
Contributor
|
This is how I updated git -C nix/dev fetch --recurse-submodules
git -C nix/dev checkout b338810dbba5a71aa4cfb59b85172a4e0caeac5e
git -C nix/dev submodule update --init --recursive |
it seems that the V8 bug (https://dfinity.atlassian.net/browse/M1-513) has gone away.
Contributor
Author
|
Ok, the new |
dfinity-bot
added a commit
that referenced
this pull request
Mar 11, 2021
## Changelog for motoko-base: Branch: next-moc Commits: [caffeinelabs/motoko-base@91ca9b25...25c152b0](caffeinelabs/motoko-base@91ca9b2...25c152b) * [`25c152b0`](caffeinelabs/motoko-base@25c152b) Add Text.{decodeUtf8,encodeUtf8} ([dfinity/motoko-base#230](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/motoko-base/issues/230))
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2021
## Changelog for motoko-base: Branch: next-moc Commits: [caffeinelabs/motoko-base@91ca9b25...25c152b0](caffeinelabs/motoko-base@91ca9b2...25c152b) * [`25c152b0`](caffeinelabs/motoko-base@25c152b) Add Text.{decodeUtf8,encodeUtf8} ([dfinity/motoko-base#230](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/motoko-base/issues/230))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.