Merged
Conversation
so that we don’t have to deal with submodules. This fails locally because it does not do recursive module checkout. But maybe this is a solution towards not needing submodules.
otherwise it does not find this non-master commit.
nomeata
changed the title
dev via nixdev via nix
Contributor
Author
|
Ok, let’s do this! |
nomeata
changed the title
dev via nixdev via nix
dfinity-bot
added a commit
that referenced
this pull request
Aug 4, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@a4222a6c...dfa125dd](https://github.com/dfinity-lab/common/compare/a4222a6c8c95a75d9d63b6c90f12ac9be1702775...dfa125dd7a24e8867e30b793a7cdb025348153bf) * [`a2a47478`](https://github.com/dfinity-lab/common/commit/a2a47478dcc1a3d47652f3c9541e9be9b3d52e6a) pkgs/overlays/lib/gitSource.nix: fix errors * [`a0d51fa4`](https://github.com/dfinity-lab/common/commit/a0d51fa4615415a44488acec7a4c0c2fb6231bda) pkgs/overlays/lib: fix bugs by moving dropString and lines to gitSource.nix * [`dfa125dd`](https://github.com/dfinity-lab/common/commit/dfa125dd7a24e8867e30b793a7cdb025348153bf) Make packager work with repoRoot changes ([dfinity-lab/common#227](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/227))
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@a4222a6c...dfa125dd](https://github.com/dfinity-lab/common/compare/a4222a6c8c95a75d9d63b6c90f12ac9be1702775...dfa125dd7a24e8867e30b793a7cdb025348153bf) * [`a2a47478`](https://github.com/dfinity-lab/common/commit/a2a47478dcc1a3d47652f3c9541e9be9b3d52e6a) pkgs/overlays/lib/gitSource.nix: fix errors * [`a0d51fa4`](https://github.com/dfinity-lab/common/commit/a0d51fa4615415a44488acec7a4c0c2fb6231bda) pkgs/overlays/lib: fix bugs by moving dropString and lines to gitSource.nix * [`dfa125dd`](https://github.com/dfinity-lab/common/commit/dfa125dd7a24e8867e30b793a7cdb025348153bf) Make packager work with repoRoot changes ([dfinity-lab/common#227](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/227))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that we don’t have to deal with submodules.
This fails locally because it does not do recursive module checkout. But
maybe this is a solution towards not needing submodules.